build/secondary/third_party/nss/BUILD.gn - Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/nss/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/secondary/third_party/nss/BUILD.gn

diff --git a/build/secondary/third_party/nss/BUILD.gn b/build/secondary/third_party/nss/BUILD.gn

index 9a08058b3c9f497846a2aff88ac75d688116350f..22228404a7962a66e516ac55c79ff2a29a09813a 100644

--- a/build/secondary/third_party/nss/BUILD.gn

+++ b/build/secondary/third_party/nss/BUILD.gn

@@ -886,6 +886,7 @@ if (is_linux) {

configs += [

"//build/config/compiler:no_chromium_code",

"//build/config/compiler:no_size_t_to_int_warning",

+ "//build/config/gcc:symbol_visibility_default",

# nss passes "const char*" through "void*".

"//build/config/compiler:no_incompatible_pointer_warnings",

« no previous file with comments | « build/config/gcc/BUILD.gn ('k') | ios/third_party/earl_grey/BUILD.gn » ('j') | no next file with comments »