Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: base/allocator/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/gcc/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/allocator.gni") 6 import("//build/config/allocator.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Provide a way to force disable debugallocation in Debug builds, 10 # Provide a way to force disable debugallocation in Debug builds,
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 # We enable all warnings by default, but upstream disables a few. 231 # We enable all warnings by default, but upstream disables a few.
232 # Keep "-Wno-*" flags in sync with upstream by comparing against: 232 # Keep "-Wno-*" flags in sync with upstream by comparing against:
233 # http://code.google.com/p/google-perftools/source/browse/trunk/Makefile.a m 233 # http://code.google.com/p/google-perftools/source/browse/trunk/Makefile.a m
234 cflags = [ 234 cflags = [
235 "-Wno-sign-compare", 235 "-Wno-sign-compare",
236 "-Wno-unused-result", 236 "-Wno-unused-result",
237 ] 237 ]
238 238
239 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 239 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
240 configs += [ "//build/config/gcc:symbol_visibility_default" ]
240 241
241 ldflags = [ 242 ldflags = [
242 # Don't let linker rip this symbol out, otherwise the heap&cpu 243 # Don't let linker rip this symbol out, otherwise the heap&cpu
243 # profilers will not initialize properly on startup. 244 # profilers will not initialize properly on startup.
244 "-Wl,-uIsHeapProfilerRunning,-uProfilerStart", 245 "-Wl,-uIsHeapProfilerRunning,-uProfilerStart",
245 246
246 # Do the same for heap leak checker. 247 # Do the same for heap leak checker.
247 "-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_j iiix,-u_Z22InitialMallocHook_SbrkPKvi", 248 "-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_j iiix,-u_Z22InitialMallocHook_SbrkPKvi",
248 "-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_m iiil,-u_Z22InitialMallocHook_SbrkPKvl", 249 "-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_m iiil,-u_Z22InitialMallocHook_SbrkPKvl",
249 "-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14Un IgnoreObjectEPKv", 250 "-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14Un IgnoreObjectEPKv",
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 sources += [ "allocator_shim_default_dispatch_to_glibc.cc" ] 306 sources += [ "allocator_shim_default_dispatch_to_glibc.cc" ]
306 } else if (is_android && use_allocator == "none") { 307 } else if (is_android && use_allocator == "none") {
307 sources += [ 308 sources += [
308 "allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc", 309 "allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc",
309 "allocator_shim_override_linker_wrapped_symbols.h", 310 "allocator_shim_override_linker_wrapped_symbols.h",
310 ] 311 ]
311 all_dependent_configs = [ ":wrap_malloc_symbols" ] 312 all_dependent_configs = [ ":wrap_malloc_symbols" ]
312 } 313 }
313 } 314 }
314 } 315 }
OLDNEW
« no previous file with comments | « no previous file | build/config/gcc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698