Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 19276009: Move ICU headers part 1 (Closed)

Created:
7 years, 5 months ago by jungshik at Google
Modified:
7 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), mark
CC:
chromium-reviews
Visibility:
Public.

Description

Move ICU headers part 1 This is a part 1 of ICU header move. I have to do this in stages because 'split gcl upload' does not work very well with a large CL. (the all-in-one CL was already approved at https://codereview.chromium.org/18836004/ ). The upstream has headers in source/{common,i18n}/unicode. With Blink's ICU headers removed, there's no need to keep them in a location different than the upstream. Future ICU updates will be a bit more streamlined. v8 also likes to have this change. The Chrome-side of change is at http://codereview.chromium.org/18252003 This revision will be rolled in along with the global replacements of include-references to ICU headers and DEPS changes. See also http://crbug.com/232922 where ICU headers in Blink are removed. BUG=251433 TEST=NONE for now. TBR=mark,cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46374 lines) Patch
D public/common/unicode/brkiter.h View 1 chunk +0 lines, -557 lines 0 comments Download
D public/common/unicode/bytestream.h View 1 chunk +0 lines, -252 lines 0 comments Download
D public/common/unicode/caniter.h View 1 chunk +0 lines, -206 lines 0 comments Download
D public/common/unicode/chariter.h View 1 chunk +0 lines, -716 lines 0 comments Download
D public/common/unicode/dbbi.h View 1 chunk +0 lines, -41 lines 0 comments Download
D public/common/unicode/docmain.h View 1 chunk +0 lines, -207 lines 0 comments Download
D public/common/unicode/dtintrv.h View 1 chunk +0 lines, -158 lines 0 comments Download
D public/common/unicode/errorcode.h View 1 chunk +0 lines, -137 lines 0 comments Download
D public/common/unicode/icudataver.h View 1 chunk +0 lines, -57 lines 0 comments Download
D public/common/unicode/icuplug.h View 1 chunk +0 lines, -370 lines 0 comments Download
D public/common/unicode/idna.h View 1 chunk +0 lines, -321 lines 0 comments Download
D public/common/unicode/localpointer.h View 1 chunk +0 lines, -300 lines 0 comments Download
D public/common/unicode/locid.h View 1 chunk +0 lines, -781 lines 0 comments Download
D public/common/unicode/normalizer2.h View 1 chunk +0 lines, -482 lines 0 comments Download
D public/common/unicode/normlzr.h View 1 chunk +0 lines, -797 lines 0 comments Download
D public/common/unicode/pandroid.h View 1 chunk +0 lines, -403 lines 0 comments Download
D public/common/unicode/parseerr.h View 1 chunk +0 lines, -92 lines 0 comments Download
D public/common/unicode/parsepos.h View 1 chunk +0 lines, -230 lines 0 comments Download
D public/common/unicode/pfreebsd.h View 1 chunk +0 lines, -401 lines 0 comments Download
D public/common/unicode/platform.h.in View 1 chunk +0 lines, -403 lines 0 comments Download
D public/common/unicode/pmac.h View 1 chunk +0 lines, -439 lines 0 comments Download
D public/common/unicode/popenbsd.h View 1 chunk +0 lines, -313 lines 0 comments Download
D public/common/unicode/ppalmos.h View 1 chunk +0 lines, -273 lines 0 comments Download
D public/common/unicode/ptypes.h View 1 chunk +0 lines, -103 lines 0 comments Download
D public/common/unicode/putil.h View 1 chunk +0 lines, -193 lines 0 comments Download
D public/common/unicode/pwin32.h View 1 chunk +0 lines, -376 lines 0 comments Download
D public/common/unicode/rbbi.h View 1 chunk +0 lines, -722 lines 0 comments Download
D public/common/unicode/rep.h View 1 chunk +0 lines, -259 lines 0 comments Download
D public/common/unicode/resbund.h View 1 chunk +0 lines, -485 lines 0 comments Download
D public/common/unicode/schriter.h View 1 chunk +0 lines, -187 lines 0 comments Download
D public/common/unicode/std_string.h View 1 chunk +0 lines, -78 lines 0 comments Download
D public/common/unicode/strenum.h View 1 chunk +0 lines, -271 lines 0 comments Download
D public/common/unicode/stringpiece.h View 1 chunk +0 lines, -224 lines 0 comments Download
D public/common/unicode/symtable.h View 1 chunk +0 lines, -112 lines 0 comments Download
D public/common/unicode/ubidi.h View 1 chunk +0 lines, -2096 lines 0 comments Download
D public/common/unicode/ubrk.h View 1 chunk +0 lines, -501 lines 0 comments Download
D public/common/unicode/ucasemap.h View 1 chunk +0 lines, -421 lines 0 comments Download
D public/common/unicode/ucat.h View 1 chunk +0 lines, -158 lines 0 comments Download
D public/common/unicode/uchar.h View 1 chunk +0 lines, -3168 lines 0 comments Download
D public/common/unicode/uchriter.h View 1 chunk +0 lines, -381 lines 0 comments Download
D public/common/unicode/uclean.h View 1 chunk +0 lines, -251 lines 0 comments Download
D public/common/unicode/ucnv.h View 1 chunk +0 lines, -1997 lines 0 comments Download
D public/common/unicode/ucnv_cb.h View 1 chunk +0 lines, -162 lines 0 comments Download
D public/common/unicode/ucnv_err.h View 1 chunk +0 lines, -463 lines 0 comments Download
D public/common/unicode/ucnvsel.h View 1 chunk +0 lines, -182 lines 0 comments Download
D public/common/unicode/uconfig.h View 1 chunk +0 lines, -231 lines 0 comments Download
D public/common/unicode/udata.h View 1 chunk +0 lines, -415 lines 0 comments Download
D public/common/unicode/udeprctd.h View 1 chunk +0 lines, -50 lines 0 comments Download
D public/common/unicode/udraft.h View 1 chunk +0 lines, -90 lines 0 comments Download
D public/common/unicode/uenum.h View 1 chunk +0 lines, -174 lines 0 comments Download
D public/common/unicode/uidna.h View 1 chunk +0 lines, -733 lines 0 comments Download
D public/common/unicode/uintrnal.h View 1 chunk +0 lines, -252 lines 0 comments Download
D public/common/unicode/uiter.h View 1 chunk +0 lines, -707 lines 0 comments Download
D public/common/unicode/uloc.h View 1 chunk +0 lines, -1126 lines 0 comments Download
D public/common/unicode/umachine.h View 1 chunk +0 lines, -374 lines 0 comments Download
D public/common/unicode/umisc.h View 1 chunk +0 lines, -60 lines 0 comments Download
D public/common/unicode/unifilt.h View 1 chunk +0 lines, -120 lines 0 comments Download
D public/common/unicode/unifunct.h View 1 chunk +0 lines, -125 lines 0 comments Download
D public/common/unicode/unimatch.h View 1 chunk +0 lines, -163 lines 0 comments Download
D public/common/unicode/uniset.h View 1 chunk +0 lines, -1673 lines 0 comments Download
D public/common/unicode/unistr.h View 1 chunk +0 lines, -4448 lines 0 comments Download
D public/common/unicode/unorm.h View 1 chunk +0 lines, -561 lines 0 comments Download
D public/common/unicode/unorm2.h View 1 chunk +0 lines, -391 lines 0 comments Download
D public/common/unicode/uobject.h View 1 chunk +0 lines, -352 lines 0 comments Download
D public/common/unicode/uobslete.h View 1 chunk +0 lines, -32 lines 0 comments Download
D public/common/unicode/urename.h View 1 chunk +0 lines, -2241 lines 0 comments Download
D public/common/unicode/urep.h View 1 chunk +0 lines, -155 lines 0 comments Download
D public/common/unicode/ures.h View 1 chunk +0 lines, -879 lines 0 comments Download
D public/common/unicode/uscript.h View 1 chunk +0 lines, -326 lines 0 comments Download
D public/common/unicode/uset.h View 1 chunk +0 lines, -1120 lines 0 comments Download
D public/common/unicode/usetiter.h View 1 chunk +0 lines, -318 lines 0 comments Download
D public/common/unicode/ushape.h View 1 chunk +0 lines, -474 lines 0 comments Download
D public/common/unicode/usprep.h View 1 chunk +0 lines, -269 lines 0 comments Download
D public/common/unicode/ustring.h View 1 chunk +0 lines, -1696 lines 0 comments Download
D public/common/unicode/usystem.h View 1 chunk +0 lines, -46 lines 0 comments Download
D public/common/unicode/utext.h View 1 chunk +0 lines, -1737 lines 0 comments Download
D public/common/unicode/utf.h View 1 chunk +0 lines, -236 lines 0 comments Download
D public/common/unicode/utf16.h View 1 chunk +0 lines, -614 lines 0 comments Download
D public/common/unicode/utf32.h View 1 chunk +0 lines, -23 lines 0 comments Download
D public/common/unicode/utf8.h View 1 chunk +0 lines, -683 lines 0 comments Download
D public/common/unicode/utf_old.h View 1 chunk +0 lines, -1173 lines 0 comments Download
D public/common/unicode/utrace.h View 1 chunk +0 lines, -358 lines 0 comments Download
D public/common/unicode/utypeinfo.h View 1 chunk +0 lines, -12 lines 0 comments Download
D public/common/unicode/utypes.h View 1 chunk +0 lines, -865 lines 0 comments Download
D public/common/unicode/uvernum.h View 1 chunk +0 lines, -151 lines 0 comments Download
D public/common/unicode/uversion.h View 1 chunk +0 lines, -195 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jungshik at Google
7 years, 5 months ago (2013-07-16 21:06:17 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r211838 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698