Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 6 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, hongchan, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, kinuko+watch, Raymond Toy, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()) This CL adds CrossThreadCopier for crossThreadUnretained() in CrossThreadCopier.h. Other changes are made by: sed -i 's/AllowCrossThreadAccess/crossThreadUnretained/g' BUG=597856 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/0df38bbadcc86525a08f663fb6b714657edd0a56 Cr-Commit-Position: refs/heads/master@{#401578}

Patch Set 1 #

Patch Set 2 : auto-Rebase #

Patch Set 3 #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -115 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTask.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 2 3 4 2 chunks +5 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorMutatorImpl.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/SpinLockTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925583003/20001
4 years, 7 months ago (2016-04-27 09:28:04 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 12:49:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925583003/40001
4 years, 7 months ago (2016-05-17 07:44:21 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/6650) ios-simulator on ...
4 years, 7 months ago (2016-05-17 07:46:40 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583003/60001
4 years, 6 months ago (2016-06-15 15:35:03 UTC) #12
hiroshige
PTAL.
4 years, 6 months ago (2016-06-15 15:36:15 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 20:12:32 UTC) #17
tzik
lgtm
4 years, 6 months ago (2016-06-18 04:38:56 UTC) #18
hiroshige
haraken@, could you take a look as an OWNER?
4 years, 6 months ago (2016-06-23 04:50:24 UTC) #20
haraken
LGTM
4 years, 6 months ago (2016-06-23 04:57:53 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583003/100001
4 years, 6 months ago (2016-06-23 08:50:17 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925583003/100001
4 years, 6 months ago (2016-06-23 09:58:36 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 6 months ago (2016-06-23 10:47:14 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 10:50:10 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0df38bbadcc86525a08f663fb6b714657edd0a56
Cr-Commit-Position: refs/heads/master@{#401578}

Powered by Google App Engine
This is Rietveld 408576698