third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp - Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

index c640a4a6ae139af996329f988f9855e07a5d1b48..cdaf05210da35c5d79e60c11b65791c111ebe5f8 100644

--- a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

@@ -138,7 +138,7 @@ void WorkerInspectorProxy::connectToInspector(WorkerInspectorProxy::PageInspecto

return;

DCHECK(!m_pageInspector);

m_pageInspector = pageInspector;

- m_workerThread->appendDebuggerTask(threadSafeBind(connectToWorkerGlobalScopeInspectorTask, AllowCrossThreadAccess(m_workerThread)));

+ m_workerThread->appendDebuggerTask(threadSafeBind(connectToWorkerGlobalScopeInspectorTask, crossThreadUnretained(m_workerThread)));

}

static void disconnectFromWorkerGlobalScopeInspectorTask(WorkerThread* workerThread)

@@ -152,7 +152,7 @@ void WorkerInspectorProxy::disconnectFromInspector(WorkerInspectorProxy::PageIns

DCHECK(m_pageInspector == pageInspector);

m_pageInspector = nullptr;

if (m_workerThread)

- m_workerThread->appendDebuggerTask(threadSafeBind(disconnectFromWorkerGlobalScopeInspectorTask, AllowCrossThreadAccess(m_workerThread)));

+ m_workerThread->appendDebuggerTask(threadSafeBind(disconnectFromWorkerGlobalScopeInspectorTask, crossThreadUnretained(m_workerThread)));

}

static void dispatchOnInspectorBackendTask(const String& message, WorkerThread* workerThread)

@@ -164,7 +164,7 @@ static void dispatchOnInspectorBackendTask(const String& message, WorkerThread*

void WorkerInspectorProxy::sendMessageToInspector(const String& message)

{

if (m_workerThread)

- m_workerThread->appendDebuggerTask(threadSafeBind(dispatchOnInspectorBackendTask, message, AllowCrossThreadAccess(m_workerThread)));

+ m_workerThread->appendDebuggerTask(threadSafeBind(dispatchOnInspectorBackendTask, message, crossThreadUnretained(m_workerThread)));

}

void WorkerInspectorProxy::writeTimelineStartedEvent(const String& sessionId)