Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 // Not suppported in SharedWorker. 224 // Not suppported in SharedWorker.
225 } 225 }
226 226
227 void WebSharedWorkerImpl::reportConsoleMessage(ConsoleMessage*) 227 void WebSharedWorkerImpl::reportConsoleMessage(ConsoleMessage*)
228 { 228 {
229 // Not supported in SharedWorker. 229 // Not supported in SharedWorker.
230 } 230 }
231 231
232 void WebSharedWorkerImpl::postMessageToPageInspector(const String& message) 232 void WebSharedWorkerImpl::postMessageToPageInspector(const String& message)
233 { 233 {
234 m_mainFrame->frame()->document()->postInspectorTask(BLINK_FROM_HERE, createC rossThreadTask(&WebSharedWorkerImpl::postMessageToPageInspectorOnMainThread, All owCrossThreadAccess(this), message)); 234 m_mainFrame->frame()->document()->postInspectorTask(BLINK_FROM_HERE, createC rossThreadTask(&WebSharedWorkerImpl::postMessageToPageInspectorOnMainThread, cro ssThreadUnretained(this), message));
235 } 235 }
236 236
237 void WebSharedWorkerImpl::postMessageToPageInspectorOnMainThread(const String& m essage) 237 void WebSharedWorkerImpl::postMessageToPageInspectorOnMainThread(const String& m essage)
238 { 238 {
239 m_workerInspectorProxy->dispatchMessageFromWorker(message); 239 m_workerInspectorProxy->dispatchMessageFromWorker(message);
240 } 240 }
241 241
242 void WebSharedWorkerImpl::workerGlobalScopeClosed() 242 void WebSharedWorkerImpl::workerGlobalScopeClosed()
243 { 243 {
244 Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_H ERE, threadSafeBind(&WebSharedWorkerImpl::workerGlobalScopeClosedOnMainThread, A llowCrossThreadAccess(this))); 244 Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_H ERE, threadSafeBind(&WebSharedWorkerImpl::workerGlobalScopeClosedOnMainThread, c rossThreadUnretained(this)));
245 } 245 }
246 246
247 void WebSharedWorkerImpl::workerGlobalScopeClosedOnMainThread() 247 void WebSharedWorkerImpl::workerGlobalScopeClosedOnMainThread()
248 { 248 {
249 m_client->workerContextClosed(); 249 m_client->workerContextClosed();
250 250
251 terminateWorkerThread(); 251 terminateWorkerThread();
252 } 252 }
253 253
254 void WebSharedWorkerImpl::workerGlobalScopeStarted(WorkerGlobalScope*) 254 void WebSharedWorkerImpl::workerGlobalScopeStarted(WorkerGlobalScope*)
255 { 255 {
256 } 256 }
257 257
258 void WebSharedWorkerImpl::workerThreadTerminated() 258 void WebSharedWorkerImpl::workerThreadTerminated()
259 { 259 {
260 Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_H ERE, threadSafeBind(&WebSharedWorkerImpl::workerThreadTerminatedOnMainThread, Al lowCrossThreadAccess(this))); 260 Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_H ERE, threadSafeBind(&WebSharedWorkerImpl::workerThreadTerminatedOnMainThread, cr ossThreadUnretained(this)));
261 } 261 }
262 262
263 void WebSharedWorkerImpl::workerThreadTerminatedOnMainThread() 263 void WebSharedWorkerImpl::workerThreadTerminatedOnMainThread()
264 { 264 {
265 m_client->workerContextDestroyed(); 265 m_client->workerContextDestroyed();
266 // The lifetime of this proxy is controlled by the worker context. 266 // The lifetime of this proxy is controlled by the worker context.
267 delete this; 267 delete this;
268 } 268 }
269 269
270 // WorkerLoaderProxyProvider --------------------------------------------------- -------- 270 // WorkerLoaderProxyProvider --------------------------------------------------- --------
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 if (devtoolsAgent) 398 if (devtoolsAgent)
399 devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method, mes sage); 399 devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method, mes sage);
400 } 400 }
401 401
402 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client) 402 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client)
403 { 403 {
404 return new WebSharedWorkerImpl(client); 404 return new WebSharedWorkerImpl(client);
405 } 405 }
406 406
407 } // namespace blink 407 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/Source/web/tests/SpinLockTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698