Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()

third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/loader/ThreadableLoader.h"
 
 #include "core/dom/CrossThreadTask.h"
 #include "core/fetch/MemoryCache.h"
 #include "core/fetch/ResourceLoaderOptions.h"
 #include "core/loader/DocumentThreadableLoader.h"
@@ skipping 145 matching lines @@
     WorkerThreadableLoaderTestHelper()
         : m_dummyPageHolder(DummyPageHolder::create(IntSize(1, 1)))
     {
     }
 
     void createLoader(ThreadableLoaderClient* client, CrossOriginRequestPolicy crossOriginRequestPolicy) override
     {
         std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());
         postTaskToWorkerGlobalScope(createCrossThreadTask(
             &WorkerThreadableLoaderTestHelper::workerCreateLoader,
-            AllowCrossThreadAccess(this),
-            AllowCrossThreadAccess(client),
-            AllowCrossThreadAccess(completionEvent.get()),
+            crossThreadUnretained(this),
+            crossThreadUnretained(client),
+            crossThreadUnretained(completionEvent.get()),
             crossOriginRequestPolicy));
         completionEvent->wait();
     }
 
     void startLoader(const ResourceRequest& request) override
     {
         std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());
         postTaskToWorkerGlobalScope(createCrossThreadTask(
             &WorkerThreadableLoaderTestHelper::workerStartLoader,
-            AllowCrossThreadAccess(this),
-            AllowCrossThreadAccess(completionEvent.get()),
+            crossThreadUnretained(this),
+            crossThreadUnretained(completionEvent.get()),
             request));
         completionEvent->wait();
     }
 
     // Must be called on the worker thread.
     void cancelLoader() override
     {
         ASSERT(m_workerThread);
         ASSERT(m_workerThread->isCurrentThread());
         m_loader->cancel();
@@ skipping 12 matching lines @@
         return m_checkpoint;
     }
 
     void callCheckpoint(int n) override
     {
         testing::runPendingTasks();
 
         std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());
         postTaskToWorkerGlobalScope(createCrossThreadTask(
             &WorkerThreadableLoaderTestHelper::workerCallCheckpoint,
-            AllowCrossThreadAccess(this),
-            AllowCrossThreadAccess(completionEvent.get()),
+            crossThreadUnretained(this),
+            crossThreadUnretained(completionEvent.get()),
             n));
         completionEvent->wait();
     }
 
     void onSetUp() override
     {
         m_mockWorkerReportingProxy = wrapUnique(new MockWorkerReportingProxy());
         m_securityOrigin = document().getSecurityOrigin();
         m_workerThread = wrapUnique(new WorkerThreadForTest(
             this,
             *m_mockWorkerReportingProxy));
 
         expectWorkerLifetimeReportingCalls();
         m_workerThread->startWithSourceCode(m_securityOrigin.get(), "//fake source code");
         m_workerThread->waitForInit();
     }
 
     void onServeRequests() override
     {
         testing::runPendingTasks();
     }
 
     void onTearDown() override
     {
-        postTaskToWorkerGlobalScope(createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader, AllowCrossThreadAccess(this)));
+        postTaskToWorkerGlobalScope(createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader, crossThreadUnretained(this)));
         m_workerThread->terminateAndWait();
 
         // Needed to clean up the things on the main thread side and
         // avoid Resource leaks.
         testing::runPendingTasks();
 
         m_workerThread->workerLoaderProxy()->detachProvider(this);
     }
 
 private:
@@ skipping 584 matching lines @@
     EXPECT_CALL(*client(), didFailRedirectCheck()).WillOnce(InvokeWithoutArgs(this, &ThreadableLoaderTest::clearLoader));
 
     startLoader(redirectLoopURL());
     callCheckpoint(2);
     serveRequests();
 }
 
 } // namespace
 
 } // namespace blink