third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp - Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('k') | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

index 39e72b0fb4bbdb5382bab440a9244e0bb628f599..1ee913c9a8af0a068891da54bc8edbb04bda1d58 100644

--- a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

+++ b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

@@ -163,9 +163,9 @@ public:

std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());

postTaskToWorkerGlobalScope(createCrossThreadTask(

&WorkerThreadableLoaderTestHelper::workerCreateLoader,

- AllowCrossThreadAccess(this),

- AllowCrossThreadAccess(client),

- AllowCrossThreadAccess(completionEvent.get()),

+ crossThreadUnretained(this),

+ crossThreadUnretained(client),

+ crossThreadUnretained(completionEvent.get()),

crossOriginRequestPolicy));

completionEvent->wait();

}

@@ -175,8 +175,8 @@ public:

std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());

postTaskToWorkerGlobalScope(createCrossThreadTask(

&WorkerThreadableLoaderTestHelper::workerStartLoader,

- AllowCrossThreadAccess(this),

- AllowCrossThreadAccess(completionEvent.get()),

+ crossThreadUnretained(this),

+ crossThreadUnretained(completionEvent.get()),

request));

completionEvent->wait();

}

@@ -209,8 +209,8 @@ public:

std::unique_ptr<WaitableEvent> completionEvent = wrapUnique(new WaitableEvent());

postTaskToWorkerGlobalScope(createCrossThreadTask(

&WorkerThreadableLoaderTestHelper::workerCallCheckpoint,

- AllowCrossThreadAccess(this),

- AllowCrossThreadAccess(completionEvent.get()),

+ crossThreadUnretained(this),

+ crossThreadUnretained(completionEvent.get()),

n));

completionEvent->wait();

}

@@ -235,7 +235,7 @@ public:

void onTearDown() override

{

- postTaskToWorkerGlobalScope(createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader, AllowCrossThreadAccess(this)));

+ postTaskToWorkerGlobalScope(createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader, crossThreadUnretained(this)));

m_workerThread->terminateAndWait();

// Needed to clean up the things on the main thread side and