third_party/WebKit/Source/web/tests/SpinLockTest.cpp - Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/tests/SpinLockTest.cpp

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 }	73 }

74 }	74 }

75	75

76 TEST(SpinLockTest, Torture)	76 TEST(SpinLockTest, Torture)

77 {	77 {

78 char sharedBuffer[bufferSize];	78 char sharedBuffer[bufferSize];

79	79

80 std::unique_ptr<WebThread> thread1 = wrapUnique(Platform::current()->createT hread("thread1"));	80 std::unique_ptr<WebThread> thread1 = wrapUnique(Platform::current()->createT hread("thread1"));

81 std::unique_ptr<WebThread> thread2 = wrapUnique(Platform::current()->createT hread("thread2"));	81 std::unique_ptr<WebThread> thread2 = wrapUnique(Platform::current()->createT hread("thread2"));

82	82

83 thread1->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&threa dMain, AllowCrossThreadAccess(static_cast<char*>(sharedBuffer))));	83 thread1->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&threa dMain, crossThreadUnretained(static_cast<char*>(sharedBuffer))));

84 thread2->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&threa dMain, AllowCrossThreadAccess(static_cast<char*>(sharedBuffer))));	84 thread2->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&threa dMain, crossThreadUnretained(static_cast<char*>(sharedBuffer))));

85	85

86 thread1.reset();	86 thread1.reset();

87 thread2.reset();	87 thread2.reset();

88 }	88 }

89	89

90 } // namespace blink	90 } // namespace blink

OLD	NEW