Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1923883003: build: use class path bases, not strings (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

build: use class path bases, not strings Depends on https://codereview.chromium.org/1925653002 TBR=martiniss BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300394

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -48 lines) Patch
M infra/config/recipes.cfg View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/api.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 7 chunks +14 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/api.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/config.py View 3 chunks +4 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/emulator/api.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/emulator/config.py View 1 chunk +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/libyuv/chromium_config.py View 1 chunk +3 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/syzygy/api.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/syzygy/config.py View 2 chunks +11 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/chromium_android_config.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-27 12:40:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923883003/1
4 years, 7 months ago (2016-04-27 21:41:49 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4425)
4 years, 7 months ago (2016-04-27 21:49:59 UTC) #6
martiniss
idea looks fine to me, but there are several breakages both in the build presubmit, ...
4 years, 7 months ago (2016-04-27 22:10:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923883003/20001
4 years, 7 months ago (2016-05-02 08:59:41 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-02 08:59:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923883003/20001
4 years, 7 months ago (2016-05-02 09:04:12 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 09:08:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300394

Powered by Google App Engine
This is Rietveld 408576698