build: use class path bases, not strings

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
@@ skipping 10 matching lines @@
   def cleanup(self, test_enabled):
     self.raw.cleanup(test_enabled)
 
 
 class ChromiumApi(recipe_api.RecipeApi):
   def __init__(self, *args, **kwargs):
     super(ChromiumApi, self).__init__(*args, **kwargs)
     self._build_properties = None
 
   def get_config_defaults(self):
-    return {
+    defaults = {
       'HOST_PLATFORM': self.m.platform.name,
       'HOST_ARCH': self.m.platform.arch,
       'HOST_BITS': self.m.platform.bits,
 
       'TARGET_PLATFORM': self.m.platform.name,
       'TARGET_ARCH': self.m.platform.arch,
       'TARGET_CROS_BOARD': None,
 
       # NOTE: This is replicating logic which lives in
       # chrome/trunk/src/build/common.gypi, which is undesirable. The desired
       # end-state is that all the configuration logic lives in one place
       # (in chromium/config.py), and the buildside gypfiles are as dumb as
       # possible. However, since the recipes need to accurately contain
       # {TARGET,HOST}_{BITS,ARCH,PLATFORM}, for use across many tools (of which
       # gyp is one tool), we're taking a small risk and replicating the logic
       # here.
       'TARGET_BITS': (
         32 if self.m.platform.name == 'win'
         else self.m.platform.bits),
 
       'BUILD_CONFIG': self.m.properties.get('build_config', 'Release'),
+
+      'CHECKOUT_PATH': self.m.path['checkout'],
     }
 
+    # Fallback in case build path is not available.
+    # TODO(phajdan.jr): get rid of the need for BUILD_PATH in config.
+    try:
+      defaults['BUILD_PATH'] = self.m.path['build']
+    except KeyError:
+      defaults['BUILD_PATH'] = self.package_repo_resource()
+
+    return defaults
+
   def get_env(self):
     ret = {}
     if self.c.env.PATH:
       ret['PATH'] = self.m.path.pathsep.join(
           map(str, self.c.env.PATH) + ['%(PATH)s'])
     if self.c.env.ADB_VENDOR_KEYS:
       ret['ADB_VENDOR_KEYS'] = self.c.env.ADB_VENDOR_KEYS
     if self.c.env.LLVM_FORCE_HEAD_REVISION:
       ret['LLVM_FORCE_HEAD_REVISION'] = self.c.env.LLVM_FORCE_HEAD_REVISION
     if self.c.env.GOMA_STUBBY_PROXY_IP_ADDRESS:
@@ skipping 668 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))