Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 1923883003: build: use class path bases, not strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/emulator/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/config.py b/scripts/slave/recipe_modules/chromium_android/config.py
index 8efbd489bad86dc9f0a801690952c2a213cb6640..2d7410ab4e4479095f8e7cf590b61e9b92e1331b 100644
--- a/scripts/slave/recipe_modules/chromium_android/config.py
+++ b/scripts/slave/recipe_modules/chromium_android/config.py
@@ -8,9 +8,10 @@ from recipe_engine.config import config_item_context, ConfigGroup
from recipe_engine.config import ConfigList, Dict, List, Single, Static
from recipe_engine.config_types import Path
-def BaseConfig(INTERNAL=False, REPO_NAME=None, REPO_URL=None,
+def BaseConfig(CHECKOUT_PATH, INTERNAL=False, REPO_NAME=None, REPO_URL=None,
BUILD_CONFIG='Debug', REVISION='', **_kwargs):
return ConfigGroup(
+ CHECKOUT_PATH = Static(CHECKOUT_PATH),
INTERNAL = Static(INTERNAL),
REPO_NAME = Static(REPO_NAME),
REPO_URL = Static(REPO_URL),
@@ -27,7 +28,7 @@ def BaseConfig(INTERNAL=False, REPO_NAME=None, REPO_URL=None,
managed = Single(bool, required=False, empty_val=True),
extra_deploy_opts = List(inner_type=basestring),
tests = List(inner_type=basestring),
- cr_build_android = Static(Path('[CHECKOUT]', 'build', 'android')),
+ cr_build_android = Static(CHECKOUT_PATH.join('build', 'android')),
test_runner = Single(Path),
gclient_custom_deps = Dict(value_type=(basestring, types.NoneType)),
channel = Single(basestring, empty_val='chrome'),
@@ -49,7 +50,7 @@ config_ctx = config_item_context(BaseConfig)
@config_ctx(is_root=True)
def base_config(c):
c.internal_dir_name = 'clank'
- c.test_runner = Path('[CHECKOUT]', 'build', 'android', 'test_runner.py')
+ c.test_runner = c.CHECKOUT_PATH.join('build', 'android', 'test_runner.py')
@config_ctx()
def main_builder(c):
« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/emulator/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698