Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 1923883003: build: use class path bases, not strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/v8/chromium_config.py
diff --git a/scripts/slave/recipe_modules/v8/chromium_config.py b/scripts/slave/recipe_modules/v8/chromium_config.py
index 8a4378d6209a955ca6e271f336ac50981d165b78..9c1994ca0504de34746038cf7195f21d9462c41e 100644
--- a/scripts/slave/recipe_modules/v8/chromium_config.py
+++ b/scripts/slave/recipe_modules/v8/chromium_config.py
@@ -19,14 +19,14 @@ def v8(c):
if c.TARGET_PLATFORM == 'android':
c.gyp_env.GYP_DEFINES['OS'] = 'android'
del c.gyp_env.GYP_DEFINES['component']
- c.build_dir = Path('[CHECKOUT]', 'out')
+ c.build_dir = c.CHECKOUT_PATH.join('out')
c.compile_py.build_tool = 'make'
if c.HOST_PLATFORM == 'mac':
c.compile_py.build_tool = 'xcode'
elif c.HOST_PLATFORM == 'win':
c.compile_py.build_tool = 'vs'
- c.build_dir = Path('[CHECKOUT]', 'build')
+ c.build_dir = c.CHECKOUT_PATH.join('build')
if c.BUILD_CONFIG == 'Debug':
c.gyp_env.GYP_DEFINES['v8_optimized_debug'] = 1
@@ -72,8 +72,8 @@ def disassembler(c):
@CONFIG_CTX(includes=['v8'])
def embed_script_mjsunit(c):
- c.gyp_env.GYP_DEFINES['embed_script'] = Path(
- '[CHECKOUT]', 'test', 'mjsunit', 'mjsunit.js')
+ c.gyp_env.GYP_DEFINES['embed_script'] = c.CHECKOUT_PATH.join(
+ 'test', 'mjsunit', 'mjsunit.js')
@CONFIG_CTX(includes=['v8'])
@@ -108,7 +108,7 @@ def jsfunfuzz(c):
@CONFIG_CTX(includes=['v8'], group='builder')
def make(c):
- c.build_dir = Path('[CHECKOUT]', 'out')
+ c.build_dir = c.CHECKOUT_PATH.join('out')
c.compile_py.build_tool = 'make'
« no previous file with comments | « scripts/slave/recipe_modules/syzygy/config.py ('k') | scripts/slave/recipe_modules/webrtc/chromium_android_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698