build: use class path bases, not strings

scripts/slave/recipe_modules/v8/chromium_config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine.config import BadConf
 from recipe_engine.config_types import Path
 from recipe_engine import config as recipe_config
 
 import DEPS
 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
 
 
 @CONFIG_CTX()
 def v8(c):
   targ_arch = c.gyp_env.GYP_DEFINES.get('target_arch')
   if not targ_arch:  # pragma: no cover
     raise recipe_config.BadConf('v8 must have a valid target_arch.')
   c.gyp_env.GYP_DEFINES['v8_target_arch'] = targ_arch
   if c.TARGET_PLATFORM == 'android':
     c.gyp_env.GYP_DEFINES['OS'] = 'android'
   del c.gyp_env.GYP_DEFINES['component']
-  c.build_dir = Path('[CHECKOUT]', 'out')
+  c.build_dir = c.CHECKOUT_PATH.join('out')
   c.compile_py.build_tool = 'make'
 
   if c.HOST_PLATFORM == 'mac':
     c.compile_py.build_tool = 'xcode'
   elif c.HOST_PLATFORM == 'win':
     c.compile_py.build_tool = 'vs'
-    c.build_dir = Path('[CHECKOUT]', 'build')
+    c.build_dir = c.CHECKOUT_PATH.join('build')
 
   if c.BUILD_CONFIG == 'Debug':
     c.gyp_env.GYP_DEFINES['v8_optimized_debug'] = 1
     c.gyp_env.GYP_DEFINES['v8_enable_slow_dchecks'] = 1
 
   # Chromium adds '_x64' to the output folder, which is only understood when
   # compiling v8 standalone with ninja.
   if c.HOST_PLATFORM == 'win' and c.TARGET_BITS == 64:
     c.build_config_fs = c.BUILD_CONFIG
     c.compile_py.pass_arch_flag = True
@@ skipping 25 matching lines @@
   c.compile_py.default_targets = ['d8']
 
 
 @CONFIG_CTX(includes=['v8'])
 def disassembler(c):
   c.gyp_env.GYP_DEFINES['v8_enable_disassembler'] = 1
 
 
 @CONFIG_CTX(includes=['v8'])
 def embed_script_mjsunit(c):
-  c.gyp_env.GYP_DEFINES['embed_script'] = Path(
-      '[CHECKOUT]', 'test', 'mjsunit', 'mjsunit.js')
+  c.gyp_env.GYP_DEFINES['embed_script'] = c.CHECKOUT_PATH.join(
+      'test', 'mjsunit', 'mjsunit.js')
 
 
 @CONFIG_CTX(includes=['v8'])
 def enable_slow_dchecks(c):
   c.gyp_env.GYP_DEFINES['v8_enable_slow_dchecks'] = 1  # pragma: no cover
 
 
 @CONFIG_CTX(includes=['v8'])
 def gcmole(c):
   c.gyp_env.GYP_DEFINES['gcmole'] = 1
@@ skipping 14 matching lines @@
   c.gyp_env.GYP_DEFINES['v8_interpreted_regexp'] = 1
 
 
 @CONFIG_CTX(includes=['v8'])
 def jsfunfuzz(c):
   c.gyp_env.GYP_DEFINES['jsfunfuzz'] = 1
 
 
 @CONFIG_CTX(includes=['v8'], group='builder')
 def make(c):
-  c.build_dir = Path('[CHECKOUT]', 'out')
+  c.build_dir = c.CHECKOUT_PATH.join('out')
   c.compile_py.build_tool = 'make'
 
 
 @CONFIG_CTX(includes=['ninja'])
 def v8_ninja(c):
   c.gyp_env.GYP_GENERATORS.add('ninja')
 
   if c.HOST_PLATFORM == 'win' and c.TARGET_BITS == 64:
     # Windows requires 64-bit builds to be in <dir>_x64 with ninja. See
     # crbug.com/470681.
@@ skipping 87 matching lines @@
 def vtunejit(c):
   c.gyp_env.GYP_DEFINES['v8_enable_vtunejit'] = 1
 
 
 @CONFIG_CTX(includes=['v8'])
 def x87(c):
   # TODO(machenbach): Chromium does not support x87 yet. With the current
   # configuration, target_arch can't be set through a parameter as ARCH=intel
   # and BITS=32 is ambigue with x87.
   c.gyp_env.GYP_DEFINES['v8_target_arch'] = 'x87'