scripts/slave/recipe_modules/emulator/config.py - Issue 1923883003: build: use class path bases, not strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/emulator/config.py

Issue 1923883003: build: use class path bases, not strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/emulator/config.py

diff --git a/scripts/slave/recipe_modules/emulator/config.py b/scripts/slave/recipe_modules/emulator/config.py

index e77057461fae23b4e6a020eb92f703822a735422..e9c9f3e2976cd2c98ee6d0090edf9558c22d341b 100644

--- a/scripts/slave/recipe_modules/emulator/config.py

+++ b/scripts/slave/recipe_modules/emulator/config.py

@@ -2,11 +2,11 @@ from recipe_engine.config import config_item_context, ConfigGroup

from recipe_engine.config import Single, Static

from recipe_engine.config_types import Path

-def BaseConfig(**_kwargs):

+def BaseConfig(CHECKOUT_PATH, **_kwargs):

return ConfigGroup(

- install_emulator_deps_path = Static(Path('[CHECKOUT]', 'build', 'android',

- 'install_emulator_deps.py')),

- avd_script_path = Static(Path('[CHECKOUT]', 'build', 'android', 'avd.py'))

+ install_emulator_deps_path = Static(

+ CHECKOUT_PATH.join('build', 'android', 'install_emulator_deps.py')),

+ avd_script_path = Static(CHECKOUT_PATH.join('build', 'android', 'avd.py')),

)

config_ctx = config_item_context(BaseConfig)