Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1925653002: recipe engine: require all path bases to be classes (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

recipe engine: require all path bases to be classes This is a step towards making the path system more object-oriented and extensible, so that more logic can be moved outside of the recipe engine. BUG=chromium:605919 Committed: https://github.com/luci/recipes-py/commit/764aae62ed63f929771542b1dc01cc518f61bb36

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M recipe_engine/config_types.py View 1 2 chunks +3 lines, -19 lines 0 comments Download
M recipe_modules/path/api.py View 1 1 chunk +1 line, -6 lines 0 comments Download
M recipe_modules/path/example.py View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-27 12:38:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925653002/1
4 years, 7 months ago (2016-04-27 12:38:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 12:40:21 UTC) #6
martiniss
lgtm
4 years, 7 months ago (2016-04-27 18:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925653002/1
4 years, 7 months ago (2016-05-02 08:18:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/207)
4 years, 7 months ago (2016-05-02 08:21:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925653002/20001
4 years, 7 months ago (2016-05-02 08:27:23 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 08:30:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/764aae62ed63f929771542b1dc01cc518f6...

Powered by Google App Engine
This is Rietveld 408576698