Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922833002: CC Animation: Start replacing int layer_id with ElementId element_id. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, shans, rjwright, kalyank, Ian Vollick, blink-reviews-animation_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, danakj+watch_chromium.org, darktears, blink-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, kinuko+watch, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Start replacing int layer_id with ElementId element_id. There is no layers in the future CC. BUG=510960 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7337a62f369a9c7e27d25448abdb8b3b06062e7a Cr-Commit-Position: refs/heads/master@{#389946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -439 lines) Patch
M cc/animation/animation_events.h View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/animation/animation_events.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/animation/animation_host.h View 4 chunks +33 lines, -32 lines 0 comments Download
M cc/animation/animation_host.cc View 20 chunks +90 lines, -85 lines 0 comments Download
M cc/animation/animation_host_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/animation_player.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/animation/animation_player.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 11 chunks +83 lines, -83 lines 0 comments Download
M cc/animation/element_animations.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/element_animations.cc View 14 chunks +29 lines, -28 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 61 chunks +165 lines, -163 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_timelines_test_common.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/mutator_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 1921583003 Patch 1
Issue 1921583003 Patch 20001
Issue 1921583003 Patch 40001
Issue 1921583003 Patch 60001

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-26 05:14:11 UTC) #4
ajuma
lgtm
4 years, 8 months ago (2016-04-26 14:39:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922833002/1
4 years, 8 months ago (2016-04-26 23:06:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 23:54:44 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 23:56:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7337a62f369a9c7e27d25448abdb8b3b06062e7a
Cr-Commit-Position: refs/heads/master@{#389946}

Powered by Google App Engine
This is Rietveld 408576698