Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1921583003: CC Animation: Let MutatorHostClient deals with elements instead of layers. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@elementid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Let MutatorHostClient deals with elements instead of layers. Replace LayerTreeType with ElementListType. This is a preparation to attach animations via ElementId mapping. BUG=510960 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fb69174e38520e118b7a2012b6a40deae2a79f6b Cr-Commit-Position: refs/heads/master@{#389961}

Patch Set 1 #

Patch Set 2 : Rename methods in AnimationHost as well. #

Patch Set 3 : Rename layer_to_element_animations_map_ #

Patch Set 4 : Rename methods in ElementAnimations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+855 lines, -808 lines) Patch
M cc/animation/animation_host.h View 1 2 6 chunks +21 lines, -21 lines 0 comments Download
M cc/animation/animation_host.cc View 1 2 3 21 chunks +82 lines, -82 lines 0 comments Download
M cc/animation/animation_host_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/animation/animation_player.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 1 6 chunks +47 lines, -47 lines 0 comments Download
M cc/animation/element_animations.h View 1 2 3 5 chunks +15 lines, -15 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 3 17 chunks +54 lines, -54 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 78 chunks +313 lines, -290 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 3 chunks +45 lines, -38 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 5 chunks +82 lines, -76 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +21 lines, -18 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 3 chunks +38 lines, -36 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +21 lines, -18 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +43 lines, -42 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 3 chunks +31 lines, -31 lines 0 comments Download
M cc/trees/mutator_host_client.h View 1 chunk +21 lines, -19 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-26 06:18:36 UTC) #6
ajuma
lgtm
4 years, 8 months ago (2016-04-26 14:39:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921583003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921583003/60001
4 years, 8 months ago (2016-04-26 23:59:28 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-27 00:59:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-27 01:00:15 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fb69174e38520e118b7a2012b6a40deae2a79f6b
Cr-Commit-Position: refs/heads/master@{#389961}

Powered by Google App Engine
This is Rietveld 408576698