Scrub the vestigal breakpad crash dump attempts metrics code.

Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448
Committed: https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574
Cr-Commit-Position: refs/heads/master@{#390161}

[Sigurður Ásgeirsson, 2016-04-25 20:20:06]

Description was changed from

==========
Scrub the vestigal breakpad crash dump attempts metrics code.

BUG=
==========

to

==========
Scrub the vestigal breakpad crash dump attempts metrics code.

BUG=606448
==========

[Sigurður Ásgeirsson, 2016-04-25 20:20:07]

siggi@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sigurður Ásgeirsson, 2016-04-25 20:20:18]

Description was changed from

==========
Scrub the vestigal breakpad crash dump attempts metrics code.

BUG=606448
==========

to

==========
Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448
==========

[Sigurður Ásgeirsson, 2016-04-25 20:26:26]

PTAL - I think this is best gone?

[scottmg, 2016-04-25 20:35:53]

I'm not familiar with this, but looks like it's not working atm, so lgtm to
remove.

If you'd rather attempt to repair it, that's fine too.

[Sigurður Ásgeirsson, 2016-04-25 20:51:03]

Hopefully there'll soon be a saner way to accomplish this...

On Mon, Apr 25, 2016, 16:35 <scottmg@chromium.org> wrote:

> I'm not familiar with this, but looks like it's not working atm, so lgtm to
> remove.
>
> If you'd rather attempt to repair it, that's fine too.
>
> https://codereview.chromium.org/1922473003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sigurður Ásgeirsson, 2016-04-26 13:45:52]

siggi@chromium.org changed reviewers:
+ asvitkine@chromium.org, grt@chromium.org

[Sigurður Ásgeirsson, 2016-04-26 13:46:09]

Greg and Alexei for owners please?

[Alexei Svitkine (slow), 2016-04-26 14:44:28]

https://codereview.chromium.org/1922473003/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider.cc (left):

https://codereview.chromium.org/1922473003/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.cc:55:
UMA_STABILITY_HISTOGRAM_ENUMERATION("CrashReport.BreakpadCrashDumpOutcome",
Please mark all the histograms you're deleting as <obsolete> in histograms.xml.
Thanks!

[Sigurður Ásgeirsson, 2016-04-26 14:53:16]

Thanks, another look?

https://codereview.chromium.org/1922473003/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider.cc (left):

https://codereview.chromium.org/1922473003/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.cc:55:
UMA_STABILITY_HISTOGRAM_ENUMERATION("CrashReport.BreakpadCrashDumpOutcome",
On 2016/04/26 14:44:28, Alexei Svitkine wrote:
> Please mark all the histograms you're deleting as <obsolete> in
histograms.xml.
> Thanks!

Done.

[Alexei Svitkine (slow), 2016-04-26 15:04:27]

lgtm

[grt (UTC plus 2), 2016-04-26 17:01:33]

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.h (right):

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:9: #include <memory>
unused

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:11: #include
"base/compiler_specific.h"
unused?

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:13: #include
"build/build_config.h"
unused

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:36: void
RecordCrashDumpAttempt(bool is_real_crash) override;
could these be removed from CrashReporterClient altogether?

[Sigurður Ásgeirsson, 2016-04-26 17:28:02]

siggi@chromium.org changed reviewers:
+ jochen@chromium.org

[Sigurður Ásgeirsson, 2016-04-26 17:28:03]

Thanks - please take one more look?

Jochen for chrome\common & components owners please?

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.h (right):

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:9: #include <memory>
On 2016/04/26 17:01:33, grt wrote:
> unused

Done.

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:11: #include
"base/compiler_specific.h"
On 2016/04/26 17:01:33, grt wrote:
> unused?

Done.

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:13: #include
"build/build_config.h"
On 2016/04/26 17:01:33, grt wrote:
> unused

Done.

https://codereview.chromium.org/1922473003/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:36: void
RecordCrashDumpAttempt(bool is_real_crash) override;
On 2016/04/26 17:01:33, grt wrote:
> could these be removed from CrashReporterClient altogether?

Yups - so removed.

[jochen (gone - plz use gerrit), 2016-04-27 12:05:54]

lgtm

[Sigurður Ásgeirsson, 2016-04-27 15:49:51]

Greg, gentle nudge.

[grt (UTC plus 2), 2016-04-27 18:32:37]

lgtm

[Sigurður Ásgeirsson, 2016-04-27 18:34:26]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2016-04-27 18:34:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1922473003/#ps60001
(title: "Address Greg's comments.")

[commit-bot: I haz the power, 2016-04-27 18:34:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922473003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922473003/60001

[commit-bot: I haz the power, 2016-04-27 20:05:10]

Description was changed from

==========
Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448
==========

to

==========
Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448
==========

[commit-bot: I haz the power, 2016-04-27 20:05:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-30 17:12:22]

Patchset 4 (id:??) landed as
https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574
Cr-Commit-Position: refs/heads/master@{#390161}

[commit-bot: I haz the power, 2016-04-30 17:51:29]

Description was changed from

==========
Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448
==========

to

==========
Scrub the vestigial breakpad crash dump attempts metrics code.

BUG=606448

Committed: https://crrev.com/f34a7582f1cf5cedbeab414d9629d524303cc574
Cr-Commit-Position: refs/heads/master@{#390161}
==========