Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: components/crash/content/app/crash_reporter_client.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 5 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
6 #define COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 6 #define COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 // Returns true if the running binary is a per-user installation. 94 // Returns true if the running binary is a per-user installation.
95 virtual bool GetIsPerUserInstall(const base::FilePath& exe_path); 95 virtual bool GetIsPerUserInstall(const base::FilePath& exe_path);
96 96
97 // Returns true if larger crash dumps should be dumped. 97 // Returns true if larger crash dumps should be dumped.
98 virtual bool GetShouldDumpLargerDumps(bool is_per_user_install); 98 virtual bool GetShouldDumpLargerDumps(bool is_per_user_install);
99 99
100 // Returns the result code to return when breakpad failed to respawn a 100 // Returns the result code to return when breakpad failed to respawn a
101 // crashed process. 101 // crashed process.
102 virtual int GetResultCodeRespawnFailed(); 102 virtual int GetResultCodeRespawnFailed();
103
104 // Invoked when initializing the crash reporter in the browser process.
105 virtual void InitBrowserCrashDumpsRegKey();
106
107 // Invoked before attempting to write a minidump.
108 virtual void RecordCrashDumpAttempt(bool is_real_crash);
109
110 // Invoked with the results of a minidump attempt.
111 virtual void RecordCrashDumpAttemptResult(bool is_real_crash, bool succeeded);
112 #endif 103 #endif
113 104
114 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS) 105 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)
115 // Returns a textual description of the product type and version to include 106 // Returns a textual description of the product type and version to include
116 // in the crash report. Neither out parameter should be set to NULL. 107 // in the crash report. Neither out parameter should be set to NULL.
117 virtual void GetProductNameAndVersion(const char** product_name, 108 virtual void GetProductNameAndVersion(const char** product_name,
118 const char** version); 109 const char** version);
119 110
120 virtual base::FilePath GetReporterLogFilename(); 111 virtual base::FilePath GetReporterLogFilename();
121 112
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 virtual bool ShouldEnableBreakpadMicrodumps(); 147 virtual bool ShouldEnableBreakpadMicrodumps();
157 #endif 148 #endif
158 149
159 // Returns true if breakpad should run in the given process type. 150 // Returns true if breakpad should run in the given process type.
160 virtual bool EnableBreakpadForProcess(const std::string& process_type); 151 virtual bool EnableBreakpadForProcess(const std::string& process_type);
161 }; 152 };
162 153
163 } // namespace crash_reporter 154 } // namespace crash_reporter
164 155
165 #endif // COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 156 #endif // COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
OLDNEW
« no previous file with comments | « components/crash/content/app/breakpad_win.cc ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698