chrome/installer/setup/installer_crash_reporter_client.h - Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/installer_crash_reporter_client.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Greg's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/installer_crash_reporter_client.h

diff --git a/chrome/installer/setup/installer_crash_reporter_client.h b/chrome/installer/setup/installer_crash_reporter_client.h

index a6ba1e5d21fe9f795b70682610ab24e9225fd322..7e869ba7043680ae07eb904bd9869d0130b16764 100644

--- a/chrome/installer/setup/installer_crash_reporter_client.h

+++ b/chrome/installer/setup/installer_crash_reporter_client.h

@@ -32,10 +32,6 @@ class InstallerCrashReporterClient

bool GetIsPerUserInstall(const base::FilePath& exe_path) override;

bool GetShouldDumpLargerDumps(bool is_per_user_install) override;

int GetResultCodeRespawnFailed() override;

- void InitBrowserCrashDumpsRegKey() override;

- void RecordCrashDumpAttempt(bool is_real_crash) override;

- void RecordCrashDumpAttemptResult(bool is_real_crash,

- bool succeeded) override;

bool GetCrashDumpLocation(base::FilePath* crash_dir) override;

size_t RegisterCrashKeys() override;

bool IsRunningUnattended() override;

« no previous file with comments | « chrome/common/metrics_constants_util_win.cc ('k') | chrome/installer/setup/installer_crash_reporter_client.cc » ('j') | no next file with comments »