components/crash/content/app/crash_reporter_client.h - Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Greg's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/app/crash_reporter_client.h

diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h

index 6eaee7bdd1a6f0e35c6023b5679dce36853e157a..66002a902c431cb07b8b4283d15709e54a17ae73 100644

--- a/components/crash/content/app/crash_reporter_client.h

+++ b/components/crash/content/app/crash_reporter_client.h

@@ -100,15 +100,6 @@ class CrashReporterClient {

// Returns the result code to return when breakpad failed to respawn a

// crashed process.

virtual int GetResultCodeRespawnFailed();

- // Invoked when initializing the crash reporter in the browser process.

- virtual void InitBrowserCrashDumpsRegKey();

- // Invoked before attempting to write a minidump.

- virtual void RecordCrashDumpAttempt(bool is_real_crash);

- // Invoked with the results of a minidump attempt.

- virtual void RecordCrashDumpAttemptResult(bool is_real_crash, bool succeeded);

#endif

#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)

« no previous file with comments | « components/crash/content/app/breakpad_win.cc ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »