Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: chrome/installer/setup/installer_crash_reporter_client.cc

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/installer_crash_reporter_client.h" 5 #include "chrome/installer/setup/installer_crash_reporter_client.h"
6 6
7 #include "base/debug/crash_logging.h" 7 #include "base/debug/crash_logging.h"
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/file_version_info.h" 9 #include "base/file_version_info.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // Use large dumps for all but the stable channel. 88 // Use large dumps for all but the stable channel.
89 return !channel.empty(); 89 return !channel.empty();
90 } 90 }
91 91
92 int InstallerCrashReporterClient::GetResultCodeRespawnFailed() { 92 int InstallerCrashReporterClient::GetResultCodeRespawnFailed() {
93 // The restart dialog is never shown for the installer. 93 // The restart dialog is never shown for the installer.
94 NOTREACHED(); 94 NOTREACHED();
95 return 0; 95 return 0;
96 } 96 }
97 97
98 void InstallerCrashReporterClient::InitBrowserCrashDumpsRegKey() {
99 // The installer does not track dump attempts and results in the registry.
100 }
101
102 void InstallerCrashReporterClient::RecordCrashDumpAttempt(bool is_real_crash) {
103 // The installer does not track dump attempts and results in the registry.
104 }
105
106 void InstallerCrashReporterClient::RecordCrashDumpAttemptResult(
107 bool is_real_crash,
108 bool succeeded) {
109 // The installer does not track dump attempts and results in the registry.
110 }
111
112 bool InstallerCrashReporterClient::GetCrashDumpLocation( 98 bool InstallerCrashReporterClient::GetCrashDumpLocation(
113 base::FilePath* crash_dir) { 99 base::FilePath* crash_dir) {
114 return PathService::Get(chrome::DIR_CRASH_DUMPS, crash_dir); 100 return PathService::Get(chrome::DIR_CRASH_DUMPS, crash_dir);
115 } 101 }
116 102
117 size_t InstallerCrashReporterClient::RegisterCrashKeys() { 103 size_t InstallerCrashReporterClient::RegisterCrashKeys() {
118 return installer::RegisterCrashKeys(); 104 return installer::RegisterCrashKeys();
119 } 105 }
120 106
121 bool InstallerCrashReporterClient::IsRunningUnattended() { 107 bool InstallerCrashReporterClient::IsRunningUnattended() {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 } 147 }
162 } 148 }
163 149
164 return false; 150 return false;
165 } 151 }
166 152
167 bool InstallerCrashReporterClient::EnableBreakpadForProcess( 153 bool InstallerCrashReporterClient::EnableBreakpadForProcess(
168 const std::string& process_type) { 154 const std::string& process_type) {
169 return true; 155 return true;
170 } 156 }
OLDNEW
« no previous file with comments | « chrome/installer/setup/installer_crash_reporter_client.h ('k') | components/browser_watcher.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698