Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 1250741914a73718add2e1e3440bdd9c08a469eb..d23f7b0a316ddde9d2776c2c3d101e35c3463357 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -27,7 +27,6 @@
#include "chrome/installer/util/google_update_settings.h"
#include "chrome/installer/util/install_util.h"
#include "chrome/installer/util/util_constants.h"
-#include "components/browser_watcher/crash_reporting_metrics_win.h"
#include "content/public/common/content_switches.h"
#include "policy/policy_constants.h"
@@ -160,40 +159,6 @@ int ChromeCrashReporterClient::GetResultCodeRespawnFailed() {
return chrome::RESULT_CODE_RESPAWN_FAILED;
}
-void ChromeCrashReporterClient::InitBrowserCrashDumpsRegKey() {
-#if !defined(NACL_WIN64)
- if (GetCollectStatsConsent()){
- crash_reporting_metrics_.reset(new browser_watcher::CrashReportingMetrics(
- chrome::GetBrowserCrashDumpAttemptsRegistryPath()));
- }
-#endif
-}
-
-void ChromeCrashReporterClient::RecordCrashDumpAttempt(bool is_real_crash) {
-#if !defined(NACL_WIN64)
- if (!crash_reporting_metrics_)
- return;
-
- if (is_real_crash)
- crash_reporting_metrics_->RecordCrashDumpAttempt();
- else
- crash_reporting_metrics_->RecordDumpWithoutCrashAttempt();
-#endif
-}
-
-void ChromeCrashReporterClient::RecordCrashDumpAttemptResult(bool is_real_crash,
- bool succeeded) {
-#if !defined(NACL_WIN64)
- if (!crash_reporting_metrics_)
- return;
-
- if (is_real_crash)
- crash_reporting_metrics_->RecordCrashDumpAttemptResult(succeeded);
- else
- crash_reporting_metrics_->RecordDumpWithoutCrashAttemptResult(succeeded);
-#endif
-}
-
bool ChromeCrashReporterClient::ReportingIsEnforcedByPolicy(
bool* breakpad_enabled) {
// Determine whether configuration management allows loading the crash reporter.
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.h ('k') | chrome/browser/metrics/chrome_stability_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698