Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3307)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 1922473003: Scrub the vestigal breakpad crash dump attempts metrics code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Greg's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.h
diff --git a/chrome/app/chrome_crash_reporter_client_win.h b/chrome/app/chrome_crash_reporter_client_win.h
index 7fcec6df364b837d99126b47d73972dc8c20358b..57bfd407f028dbd4e6a25b29c62298c04ca4adde 100644
--- a/chrome/app/chrome_crash_reporter_client_win.h
+++ b/chrome/app/chrome_crash_reporter_client_win.h
@@ -5,18 +5,9 @@
#ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
#define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
-#include <stddef.h>
-#include <memory>
-
-#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "build/build_config.h"
#include "components/crash/content/app/crash_reporter_client.h"
-namespace browser_watcher {
-class CrashReportingMetrics;
-} // namespace browser_watcher
-
class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
public:
ChromeCrashReporterClient();
@@ -37,10 +28,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
int GetResultCodeRespawnFailed() override;
- void InitBrowserCrashDumpsRegKey() override;
- void RecordCrashDumpAttempt(bool is_real_crash) override;
- void RecordCrashDumpAttemptResult(bool is_real_crash,
- bool succeeded) override;
bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
@@ -55,9 +42,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool EnableBreakpadForProcess(const std::string& process_type) override;
private:
- std::unique_ptr<browser_watcher::CrashReportingMetrics>
- crash_reporting_metrics_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
};
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698