Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1889533002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move v8-related instrumentation from agents to InspectorSession. Added V8InspectorSessionClient which gets notified when instrumentation should start and stop. BUG=590878, 580337 Committed: https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806 Cr-Commit-Position: refs/heads/master@{#389556}

Patch Set 1 #

Patch Set 2 : rebased, fixed order #

Patch Set 3 : profiler agent restore starts instrumenting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -150 lines) Patch
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 2 chunks +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 4 chunks +21 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 3 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 4 chunks +34 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 2 4 chunks +131 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 3 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 1 2 4 chunks +18 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Could you please take a look?
4 years, 8 months ago (2016-04-22 23:50:16 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-23 02:32:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907663005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907663005/20001
4 years, 8 months ago (2016-04-24 01:06:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/151038)
4 years, 8 months ago (2016-04-24 02:47:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907663005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907663005/40001
4 years, 8 months ago (2016-04-25 19:17:53 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 20:42:22 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:44:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/821ac29a26b665d65f674d6ccf88590ad91c5806
Cr-Commit-Position: refs/heads/master@{#389556}

Powered by Google App Engine
This is Rietveld 408576698