Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002
Patch Set: profiler agent restore starts instrumenting Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
index 18551341c1f04af20bf8d56d35181202c7340d45..e3bd1a13555094ddc9208b5b15484d3a880466dc 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
@@ -31,7 +31,6 @@
#include "bindings/core/v8/ScriptCallStack.h"
#include "bindings/core/v8/V8Binding.h"
-#include "core/frame/UseCounter.h"
#include "platform/v8_inspector/public/V8ProfilerAgent.h"
namespace blink {
@@ -83,12 +82,10 @@ void InspectorProfilerAgent::enable(ErrorString* errorString)
{
m_v8ProfilerAgent->enable(errorString);
m_state->setBoolean(ProfilerAgentState::profilerEnabled, true);
- m_instrumentingAgents->setInspectorProfilerAgent(this);
}
void InspectorProfilerAgent::disable(ErrorString* errorString)
{
- m_instrumentingAgents->setInspectorProfilerAgent(nullptr);
m_state->setBoolean(ProfilerAgentState::profilerEnabled, false);
m_v8ProfilerAgent->disable(errorString);
}
@@ -112,26 +109,6 @@ void InspectorProfilerAgent::stop(ErrorString* errorString, OwnPtr<protocol::Pro
m_v8ProfilerAgent->stop(errorString, profile);
}
-void InspectorProfilerAgent::willProcessTask()
-{
- m_v8ProfilerAgent->idleFinished();
-}
-
-void InspectorProfilerAgent::didProcessTask()
-{
- m_v8ProfilerAgent->idleStarted();
-}
-
-void InspectorProfilerAgent::willEnterNestedRunLoop()
-{
- m_v8ProfilerAgent->idleStarted();
-}
-
-void InspectorProfilerAgent::didLeaveNestedRunLoop()
-{
- m_v8ProfilerAgent->idleFinished();
-}
-
DEFINE_TRACE(InspectorProfilerAgent)
{
InspectorBaseAgent::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698