third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h - Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002

Patch Set: profiler agent restore starts instrumenting Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

index d8befe1463d5a91ae6562a6c792322b83fd6c948..88fcab1c076ef46250661ac8ce9e02348eeec582 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

@@ -12,6 +12,7 @@ namespace blink {

class V8DebuggerAgent;

class V8HeapProfilerAgent;

+class V8InspectorSessionClient;

class V8ProfilerAgent;

class V8RuntimeAgent;

@@ -19,6 +20,8 @@ class PLATFORM_EXPORT V8InspectorSession {

public:

virtual ~V8InspectorSession() { }

+ virtual void setClient(V8InspectorSessionClient*) = 0;

virtual V8DebuggerAgent* debuggerAgent() = 0;

virtual V8HeapProfilerAgent* heapProfilerAgent() = 0;

virtual V8ProfilerAgent* profilerAgent() = 0;