Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002
Patch Set: profiler agent restore starts instrumenting Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp
index c6bb1d5ebc60fa5920ee70620a7de283d10ba6c0..f7992d5dd2b20dc72e3501d5c1147a7b54e15679 100644
--- a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp
@@ -63,12 +63,6 @@ void PageRuntimeAgent::enable(ErrorString* errorString)
{
if (m_enabled)
return;
-
- m_instrumentingAgents->setPageRuntimeAgent(this);
- if (m_inspectedFrames->root()->loader().stateMachine()->committedFirstRealDocumentLoad()) {
- for (const LocalFrame* frame : *m_inspectedFrames)
- frame->script().initializeMainWorld();
- }
InspectorRuntimeAgent::enable(errorString);
}
@@ -77,12 +71,6 @@ void PageRuntimeAgent::disable(ErrorString* errorString)
if (!m_enabled)
return;
InspectorRuntimeAgent::disable(errorString);
- m_instrumentingAgents->setPageRuntimeAgent(nullptr);
-}
-
-void PageRuntimeAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
-{
- frame->script().initializeMainWorld();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698