Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002
Patch Set: profiler agent restore starts instrumenting Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
diff --git a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
index 4d4f1fde0ebe6a5547413f664471421af50321db..431b22293cdfd94cdc3c73d9a08dea22a333c60a 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
+++ b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
@@ -71,7 +71,7 @@ class WorkerInspectorProxy;
class XMLHttpRequest;
// We should call PageDebuggerAgent method first otherwise this method resets script cache and removes scripts executed by other agents.
- [PageRuntime, Page, Animation]
+ [V8, Page, Animation]
void didClearDocumentOfWindowObject([Keep] LocalFrame*);
[DOMDebugger]
@@ -206,13 +206,13 @@ class XMLHttpRequest;
[Resource]
void scriptImported(ExecutionContext*, unsigned long identifier, const String& sourceString);
- [Debugger]
+ [V8]
void scriptExecutionBlockedByCSP(ExecutionContext*, const String& directiveText);
[Resource]
void didReceiveScriptResponse(ExecutionContext*, unsigned long identifier);
- [PageDebugger]
+ [V8]
void didStartProvisionalLoad([Keep] LocalFrame*);
[DOM, Page]
@@ -257,17 +257,23 @@ class XMLHttpRequest;
[Worker, PageConsole]
void workerTerminated(ExecutionContext*, WorkerInspectorProxy* proxy);
- [Profiler]
- void willProcessTask(WorkerGlobalScope* context);
+ [V8]
+ void willProcessTask(WorkerGlobalScope*);
- [Profiler]
- void didProcessTask(WorkerGlobalScope* context);
+ [V8]
+ void didProcessTask(WorkerGlobalScope*);
- [Profiler]
- void willEnterNestedRunLoop(WorkerGlobalScope* context);
+ [V8]
+ void willProcessTask(LocalFrame*);
- [Profiler]
- void didLeaveNestedRunLoop(WorkerGlobalScope* context);
+ [V8]
+ void didProcessTask(LocalFrame*);
+
+ [V8]
+ void willEnterNestedRunLoop(WorkerGlobalScope*);
+
+ [V8]
+ void didLeaveNestedRunLoop(WorkerGlobalScope*);
[Resource]
void didCreateWebSocket([Keep] Document*, unsigned long identifier, const KURL& requestURL, const String& protocol);
@@ -305,16 +311,16 @@ class XMLHttpRequest;
[DOM]
void pseudoElementDestroyed([Keep] PseudoElement*);
- [Debugger]
+ [V8]
void asyncTaskScheduled(ExecutionContext*, const String& name, void*);
- [Debugger]
+ [V8]
void asyncTaskScheduled(ExecutionContext*, const String& name, void*, bool recurring);
- [Debugger]
+ [V8]
void asyncTaskCanceled(ExecutionContext*, void*);
- [Debugger]
+ [V8]
void allAsyncTasksCanceled(ExecutionContext*);
[Animation]

Powered by Google App Engine
This is Rietveld 408576698