Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002
Patch Set: profiler agent restore starts instrumenting Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 DEFINE_TRACE(PageRuntimeAgent) 56 DEFINE_TRACE(PageRuntimeAgent)
57 { 57 {
58 visitor->trace(m_inspectedFrames); 58 visitor->trace(m_inspectedFrames);
59 InspectorRuntimeAgent::trace(visitor); 59 InspectorRuntimeAgent::trace(visitor);
60 } 60 }
61 61
62 void PageRuntimeAgent::enable(ErrorString* errorString) 62 void PageRuntimeAgent::enable(ErrorString* errorString)
63 { 63 {
64 if (m_enabled) 64 if (m_enabled)
65 return; 65 return;
66
67 m_instrumentingAgents->setPageRuntimeAgent(this);
68 if (m_inspectedFrames->root()->loader().stateMachine()->committedFirstRealDo cumentLoad()) {
69 for (const LocalFrame* frame : *m_inspectedFrames)
70 frame->script().initializeMainWorld();
71 }
72 InspectorRuntimeAgent::enable(errorString); 66 InspectorRuntimeAgent::enable(errorString);
73 } 67 }
74 68
75 void PageRuntimeAgent::disable(ErrorString* errorString) 69 void PageRuntimeAgent::disable(ErrorString* errorString)
76 { 70 {
77 if (!m_enabled) 71 if (!m_enabled)
78 return; 72 return;
79 InspectorRuntimeAgent::disable(errorString); 73 InspectorRuntimeAgent::disable(errorString);
80 m_instrumentingAgents->setPageRuntimeAgent(nullptr);
81 }
82
83 void PageRuntimeAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
84 {
85 frame->script().initializeMainWorld();
86 } 74 }
87 75
88 } // namespace blink 76 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698