third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp - Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Issue 1907663005: [DevTools] Move v8-related instrumentation from agents to InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1889533002

Patch Set: profiler agent restore starts instrumenting Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

index bc0c434927a0ca3582bd333918eff40cc34ac2b4..7f93c6e6a24e92fe8a64e473cfb6de6313ee3558 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

@@ -74,7 +74,7 @@ void WorkerInspectorController::connectFrontend()

return;

// sessionId will be overwritten by WebDevToolsAgent::sendProtocolNotifications call.

- m_session = new InspectorSession(this, 0, true /* autoFlush */);

+ m_session = new InspectorSession(this, nullptr, 0, true /* autoFlush */);

m_v8Session = m_debugger->debugger()->connect(m_debugger->contextGroupId());

m_session->append(WorkerRuntimeAgent::create(m_v8Session->runtimeAgent(), m_workerGlobalScope, this));

@@ -87,7 +87,7 @@ void WorkerInspectorController::connectFrontend()

m_v8Session->runtimeAgent()->setClearConsoleCallback(bind<>(&InspectorConsoleAgent::clearAllMessages, workerConsoleAgent));

m_instrumentingSessions->add(m_session);

- m_session->attach(nullptr);

+ m_session->attach(m_v8Session.get(), nullptr);

}

void WorkerInspectorController::disconnectFrontend()