[GN/iOS] Explicitly list test data in //components.

[GN/iOS] Explicitly list test data in //components.

Since timestamp of directory is not always updated when the content
is changed (e.g. when a file content is changed, ...) listing just
the directory lead to flaky incremental builds and bot failures.

Explicitly list all test data files to fix those flakes. To make it
more manageable, create individual bundle_data for all unit_tests
target that require them and put the individual files used there.

Enable the same set of unit tests on iOS with gyp and gn and fix some
minor errors in the BUILD.gn files to get the target to build and link.

BUG=459705, 604721
Committed: https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc
Cr-Commit-Position: refs/heads/master@{#388248}

[sdefresne, 2016-04-19 11:26:27]

sdefresne@chromium.org changed reviewers:
+ rsesek@chromium.org

[sdefresne, 2016-04-19 11:26:27]

Please take a look.

[Robert Sesek, 2016-04-19 12:17:42]

LGTM

https://codereview.chromium.org/1903443002/diff/1/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1903443002/diff/1/components/BUILD.gn#newcode69
components/BUILD.gn:69: "//components/cloud_devices/common:unit_tests",
Listed twice.

[sdefresne, 2016-04-19 16:55:29]

Description was changed from

==========
[GN/iOS] Explicitly list test data in //components.

Since timestamp of directory is not always updated when the content
is changed (e.g. when a file content is changed, ...) listing just
the directory lead to flaky incremental builds and bot failures.

Explicitly list all test data files to fix those flakes. To make it
more manageable, create individual bundle_data for all unit_tests
target that require them and put the individual files used there.

Enable the same set of unit tests on iOS with gyp and gn and fix some
minor errors in the BUILD.gn files to get the target to build and link.

BUG=459705
==========

to

==========
[GN/iOS] Explicitly list test data in //components.

Since timestamp of directory is not always updated when the content
is changed (e.g. when a file content is changed, ...) listing just
the directory lead to flaky incremental builds and bot failures.

Explicitly list all test data files to fix those flakes. To make it
more manageable, create individual bundle_data for all unit_tests
target that require them and put the individual files used there.

Enable the same set of unit tests on iOS with gyp and gn and fix some
minor errors in the BUILD.gn files to get the target to build and link.

BUG=459705,604721
==========

[sdefresne, 2016-04-19 17:11:48]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2016-04-19 17:11:55]

Patchset #2 (id:40001) has been deleted

[sdefresne, 2016-04-19 17:12:41]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-04-19 17:12:41]

Thank you for the review.

https://codereview.chromium.org/1903443002/diff/1/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1903443002/diff/1/components/BUILD.gn#newcode69
components/BUILD.gn:69: "//components/cloud_devices/common:unit_tests",
On 2016/04/19 at 12:17:42, Robert Sesek wrote:
> Listed twice.

Thank done.

[sdefresne, 2016-04-19 17:12:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1903443002/#ps60001
(title: "Address comments and disable non-fonctional test")

[commit-bot: I haz the power, 2016-04-19 17:13:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903443002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903443002/60001

[sdefresne, 2016-04-19 17:14:31]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-04-19 17:25:07]

Patchset #2 (id:60001) has been deleted

[sdefresne, 2016-04-19 17:31:44]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-04-19 17:31:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1903443002/#ps80001
(title: "Address comments and disable non-fonctional test")

[commit-bot: I haz the power, 2016-04-19 17:32:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903443002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903443002/80001

[commit-bot: I haz the power, 2016-04-19 18:19:41]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:13:52]

Description was changed from

==========
[GN/iOS] Explicitly list test data in //components.

Since timestamp of directory is not always updated when the content
is changed (e.g. when a file content is changed, ...) listing just
the directory lead to flaky incremental builds and bot failures.

Explicitly list all test data files to fix those flakes. To make it
more manageable, create individual bundle_data for all unit_tests
target that require them and put the individual files used there.

Enable the same set of unit tests on iOS with gyp and gn and fix some
minor errors in the BUILD.gn files to get the target to build and link.

BUG=459705,604721
==========

to

==========
[GN/iOS] Explicitly list test data in //components.

Since timestamp of directory is not always updated when the content
is changed (e.g. when a file content is changed, ...) listing just
the directory lead to flaky incremental builds and bot failures.

Explicitly list all test data files to fix those flakes. To make it
more manageable, create individual bundle_data for all unit_tests
target that require them and put the individual files used there.

Enable the same set of unit tests on iOS with gyp and gn and fix some
minor errors in the BUILD.gn files to get the target to build and link.

BUG=459705,604721

Committed: https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc
Cr-Commit-Position: refs/heads/master@{#388248}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:53]

Patchset 2 (id:??) landed as
https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc
Cr-Commit-Position: refs/heads/master@{#388248}