Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 1903443002: [GN/iOS] Explicitly list test data in //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-jingle
Patch Set: Address comments and disable non-fonctional test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/BUILD.gn
diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn
index 7752be82b0870a428a45d879c9f3bb1cefbefe49..2fa30ff1dfe304d655a0b4e953452ec2fb16eb9e 100644
--- a/components/password_manager/core/browser/BUILD.gn
+++ b/components/password_manager/core/browser/BUILD.gn
@@ -193,6 +193,38 @@ source_set("test_support") {
]
}
+bundle_data("unit_tests_bundle_data") {
+ visibility = [ ":unit_tests" ]
+ testonly = true
+ sources = [
+ "//components/test/data/password_manager/login_db_v1.sql",
+ "//components/test/data/password_manager/login_db_v10.sql",
+ "//components/test/data/password_manager/login_db_v11.sql",
+ "//components/test/data/password_manager/login_db_v12.sql",
+ "//components/test/data/password_manager/login_db_v13.sql",
+ "//components/test/data/password_manager/login_db_v14.sql",
+ "//components/test/data/password_manager/login_db_v15.sql",
+ "//components/test/data/password_manager/login_db_v16.sql",
+ "//components/test/data/password_manager/login_db_v17.sql",
+ "//components/test/data/password_manager/login_db_v1_broken.sql",
+ "//components/test/data/password_manager/login_db_v2.sql",
+ "//components/test/data/password_manager/login_db_v2_broken.sql",
+ "//components/test/data/password_manager/login_db_v3.sql",
+ "//components/test/data/password_manager/login_db_v3_broken.sql",
+ "//components/test/data/password_manager/login_db_v4.sql",
+ "//components/test/data/password_manager/login_db_v5.sql",
+ "//components/test/data/password_manager/login_db_v6.sql",
+ "//components/test/data/password_manager/login_db_v7.sql",
+ "//components/test/data/password_manager/login_db_v8.sql",
+ "//components/test/data/password_manager/login_db_v9.sql",
+ "//components/test/data/password_manager/login_db_v9_without_use_additional_auth_field.sql",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/" +
+ "{{source_root_relative_dir}}/{{source_file_part}}",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
@@ -228,6 +260,7 @@ source_set("unit_tests") {
]
deps = [
":test_support",
+ ":unit_tests_bundle_data",
"//base/test:test_support",
"//components/autofill/core/browser:test_support",
"//components/autofill/core/browser/proto",

Powered by Google App Engine
This is Rietveld 408576698