components/security_state/BUILD.gn - Issue 1903443002: [GN/iOS] Explicitly list test data in //components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_state/BUILD.gn

Issue 1903443002: [GN/iOS] Explicitly list test data in //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-jingle

Patch Set: Address comments and disable non-fonctional test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc ('k') | components/update_client/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_state/BUILD.gn

diff --git a/components/security_state/BUILD.gn b/components/security_state/BUILD.gn

index 68cd2827e09b3bc6563af508712999395f9e3e2e..d6b37cfeb84df78dfa6d9ae0496bf412450f3365 100644

--- a/components/security_state/BUILD.gn

+++ b/components/security_state/BUILD.gn

@@ -32,6 +32,18 @@ if (is_android) {

}

+bundle_data("unit_tests_bundle_data") {

+ visibility = [ ":unit_tests" ]

+ testonly = true

+ sources = [

+ "//net/data/ssl/certificates/sha1_2016.pem",

+ ]

+ outputs = [

+ "{{bundle_resources_dir}}/" +

+ "{{source_root_relative_dir}}/{{source_file_part}}",

+ ]

source_set("unit_tests") {

testonly = true

sources = [

@@ -40,6 +52,7 @@ source_set("unit_tests") {

deps = [

":security_state",

+ ":unit_tests_bundle_data",

"//net:test_support",

"//testing/gtest",

]