Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: components/bookmarks/browser/BUILD.gn

Issue 1903443002: [GN/iOS] Explicitly list test data in //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-jingle
Patch Set: Address comments and disable non-fonctional test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 6
7 source_set("browser") { 7 source_set("browser") {
8 sources = [ 8 sources = [
9 "base_bookmark_model_observer.cc", 9 "base_bookmark_model_observer.cc",
10 "base_bookmark_model_observer.h", 10 "base_bookmark_model_observer.h",
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 "//ui/gfx", 61 "//ui/gfx",
62 "//url", 62 "//url",
63 ] 63 ]
64 64
65 if (toolkit_views) { 65 if (toolkit_views) {
66 sources += [ "bookmark_node_data_views.cc" ] 66 sources += [ "bookmark_node_data_views.cc" ]
67 deps += [ "//ui/views" ] 67 deps += [ "//ui/views" ]
68 } 68 }
69 } 69 }
70 70
71 bundle_data("unit_tests_bundle_data") {
72 visibility = [ ":unit_tests" ]
73 testonly = true
74 sources = [
75 "//components/test/data/bookmarks/meta_info_as_string.json",
76 "//components/test/data/bookmarks/model_without_sync.json",
77 ]
78 outputs = [
79 "{{bundle_resources_dir}}/" +
80 "{{source_root_relative_dir}}/{{source_file_part}}",
81 ]
82 }
83
71 source_set("unit_tests") { 84 source_set("unit_tests") {
72 testonly = true 85 testonly = true
73 sources = [ 86 sources = [
74 "bookmark_codec_unittest.cc", 87 "bookmark_codec_unittest.cc",
75 "bookmark_expanded_state_tracker_unittest.cc", 88 "bookmark_expanded_state_tracker_unittest.cc",
76 "bookmark_index_unittest.cc", 89 "bookmark_index_unittest.cc",
77 "bookmark_model_unittest.cc", 90 "bookmark_model_unittest.cc",
78 "bookmark_utils_unittest.cc", 91 "bookmark_utils_unittest.cc",
79 ] 92 ]
80 93
81 if (toolkit_views) { 94 if (toolkit_views) {
82 sources += [ "bookmark_node_data_unittest.cc" ] 95 sources += [ "bookmark_node_data_unittest.cc" ]
83 } 96 }
84 97
85 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 98 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
86 99
87 deps = [ 100 deps = [
88 ":browser", 101 ":browser",
102 ":unit_tests_bundle_data",
89 "//components/bookmarks/common", 103 "//components/bookmarks/common",
90 "//components/bookmarks/test", 104 "//components/bookmarks/test",
91 "//components/favicon_base", 105 "//components/favicon_base",
92 "//components/pref_registry", 106 "//components/pref_registry",
93 "//components/prefs", 107 "//components/prefs",
94 "//components/prefs:test_support", 108 "//components/prefs:test_support",
95 "//testing/gtest", 109 "//testing/gtest",
96 "//ui/base", 110 "//ui/base",
97 "//url", 111 "//url",
98 ] 112 ]
99 } 113 }
OLDNEW
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/data_reduction_proxy/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698