components/user_prefs/tracked/BUILD.gn - Issue 1903443002: [GN/iOS] Explicitly list test data in //components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/BUILD.gn

Issue 1903443002: [GN/iOS] Explicitly list test data in //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-jingle

Patch Set: Address comments and disable non-fonctional test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/user_prefs/tracked/BUILD.gn

diff --git a/components/user_prefs/tracked/BUILD.gn b/components/user_prefs/tracked/BUILD.gn

index 8a855eebf51426f93c425e5bcd3bcc8d03c7b8e5..3afd2bc77446cde3dba854341b66cb56cf5c371a 100644

--- a/components/user_prefs/tracked/BUILD.gn

+++ b/components/user_prefs/tracked/BUILD.gn

@@ -41,14 +41,10 @@ static_library("user_prefs_tracked") {

"tracked_split_preference.h",

]

- if (is_win || (is_mac && !is_ios)) {

+ if (is_win || is_mac) {

sources -= [ "device_id_stub.cc" ]

}

- if (is_ios) {

- sources -= [ "device_id_mac.cc" ]

- }

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

« no previous file with comments | « components/update_client/BUILD.gn ('k') | components/webdata/common/BUILD.gn » ('j') | no next file with comments »