Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/BUILD.gn

Issue 1903443002: [GN/iOS] Explicitly list test data in //components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-jingle
Patch Set: Address comments and disable non-fonctional test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 999d71d0176fb3c81c0d8425a3f8b6cb64650f1b..636cecf14d7868148b3fb68c8a8c6230bd78ae2b 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -31,18 +31,6 @@ if (is_ios || is_mac) {
}
}
-bundle_data("components_unittests_bundle_data") {
- sources = [
- "//third_party/dom_distiller_js/dist/test/data",
- "dom_distiller/core/javascript",
- "test/data",
- ]
- outputs = [
- "{{bundle_resources_dir}}/" +
- "{{source_root_relative_dir}}/{{source_file_part}}",
- ]
-}
-
# To add a unit test to this target, make a "unit_test" source_set in your
# component (it's important to use a source_set instead of a static library or
# no tests will run) and add a reference here. You can add more than one unit
@@ -67,33 +55,71 @@ test("components_unittests") {
# test source set and not here.
deps = [
- ":components_unittests_bundle_data",
"//base",
"//base/test:test_support",
+ "//components/auto_login_parser:unit_tests",
+ "//components/autofill/core/browser:unit_tests",
+ "//components/autofill/core/common:unit_tests",
"//components/bookmarks/browser:unit_tests",
"//components/bookmarks/managed:unit_tests",
+ "//components/browser_sync/browser:unit_tests",
+ "//components/bubble:unit_tests",
+ "//components/captive_portal:unit_tests",
"//components/client_update_protocol:unit_tests",
+ "//components/cloud_devices/common:unit_tests",
+ "//components/component_updater:unit_tests",
"//components/content_settings/core/browser:unit_tests",
- "//components/content_settings/core/common",
"//components/content_settings/core/common:unit_tests",
+ "//components/crx_file:unit_tests",
+ "//components/data_reduction_proxy/core/browser:unit_tests",
+ "//components/data_reduction_proxy/core/common:unit_tests",
"//components/data_usage/core:unit_tests",
+ "//components/device_event_log:unit_tests",
"//components/dom_distiller/core:unit_tests",
+ "//components/favicon/core:unit_tests",
+ "//components/favicon_base:unit_tests",
"//components/flags_ui:unit_tests",
+ "//components/gcm_driver:unit_tests",
+ "//components/gcm_driver/crypto:unit_tests",
"//components/google/core/browser:unit_tests",
+ "//components/history/core/browser:unit_tests",
+ "//components/history/core/common:unit_tests",
+ "//components/json_schema:unit_tests",
"//components/keyed_service/core:unit_tests",
+ "//components/language_usage_metrics:unit_tests",
"//components/leveldb_proto:unit_tests",
+ "//components/login:unit_tests",
+ "//components/memory_pressure:unit_tests",
"//components/metrics:unit_tests",
+ "//components/mime_util:unit_tests",
"//components/net_log:unit_tests",
"//components/network_time:unit_tests",
"//components/ntp_snippets:unit_tests",
+ "//components/offline_pages:unit_tests",
+ "//components/omnibox/browser:unit_tests",
"//components/open_from_clipboard:unit_tests",
"//components/os_crypt:unit_tests",
+ "//components/password_manager/core/browser:unit_tests",
+ "//components/password_manager/core/common:unit_tests",
+ "//components/password_manager/sync/browser:unit_tests",
+ "//components/precache/core:unit_tests",
"//components/prefs:unit_tests",
"//components/proxy_config:unit_tests",
+ "//components/query_parser:unit_tests",
+ "//components/rappor:unit_tests",
+ "//components/search:unit_tests",
+ "//components/search_engines:unit_tests",
+ "//components/search_provider_logos:unit_tests",
"//components/security_state:unit_tests",
"//components/sessions:unit_tests",
+ "//components/signin/core/browser:unit_tests",
+ "//components/ssl_config:unit_tests",
+ "//components/ssl_errors:unit_tests",
"//components/suggestions:unit_tests",
"//components/supervised_user_error_page:unit_tests",
+ "//components/sync_bookmarks:unit_tests",
+ "//components/sync_driver:unit_tests",
+ "//components/sync_sessions:unit_tests",
"//components/syncable_prefs:unit_tests",
"//components/translate/core/browser:unit_tests",
"//components/translate/core/common:unit_tests",
@@ -101,9 +127,16 @@ test("components_unittests") {
"//components/undo:unit_tests",
"//components/update_client:unit_tests",
"//components/upload_list:unit_tests",
+ "//components/url_formatter:unit_tests",
+ "//components/url_matcher:unit_tests",
+ "//components/user_prefs/tracked:unit_tests",
"//components/variations:unit_tests",
"//components/variations/service:unit_tests",
"//components/web_resource:unit_tests",
+ "//components/webdata/common:unit_tests",
+
+ # Direct dependencies of components/test/run_all_unittests.cc.
+ "//components/content_settings/core/common",
"//net",
"//testing/gtest",
"//ui/base",
@@ -122,82 +155,38 @@ test("components_unittests") {
}
} else { # !iOS
deps += [
- "//components/auto_login_parser:unit_tests",
"//components/autofill/content/browser:unit_tests",
"//components/autofill/content/renderer:unit_tests",
- "//components/autofill/core/browser:unit_tests",
- "//components/autofill/core/common:unit_tests",
- "//components/browser_sync/browser:unit_tests",
- "//components/bubble:unit_tests",
- "//components/captive_portal:unit_tests",
"//components/certificate_transparency:unit_tests",
- "//components/cloud_devices/common:unit_tests",
- "//components/component_updater:unit_tests",
- "//components/crx_file:unit_tests",
"//components/data_reduction_proxy/content/browser:unit_tests",
- "//components/data_reduction_proxy/core/browser:unit_tests",
- "//components/data_reduction_proxy/core/common:unit_tests",
"//components/data_use_measurement/content:unit_tests",
- "//components/device_event_log:unit_tests",
"//components/devtools_http_handler:unit_tests",
"//components/dom_distiller/content/browser:unit_tests",
"//components/domain_reliability:unit_tests",
"//components/error_page/renderer:unit_tests",
"//components/favicon/content:unit_tests",
- "//components/favicon/core:unit_tests",
- "//components/favicon_base:unit_tests",
- "//components/gcm_driver:unit_tests",
- "//components/gcm_driver/crypto:unit_tests",
"//components/guest_view/browser:unit_tests",
"//components/history/content/browser:unit_tests",
- "//components/history/core/browser:unit_tests",
- "//components/history/core/common:unit_tests",
"//components/invalidation/impl:unit_tests",
- "//components/json_schema:unit_tests",
"//components/keyed_service/content:unit_tests",
- "//components/language_usage_metrics:unit_tests",
- "//components/login:unit_tests",
- "//components/memory_pressure:unit_tests",
- "//components/mime_util:unit_tests",
"//components/navigation_interception:unit_tests",
"//components/network_hints/renderer:unit_tests",
- "//components/offline_pages:unit_tests",
- "//components/omnibox/browser:unit_tests",
"//components/packed_ct_ev_whitelist:unit_tests",
"//components/page_load_metrics/browser:unit_tests",
"//components/page_load_metrics/renderer:unit_tests",
"//components/password_manager/content/browser:unit_tests",
- "//components/password_manager/core/browser:unit_tests",
- "//components/password_manager/core/common:unit_tests",
- "//components/password_manager/sync/browser:unit_tests",
"//components/power:unit_tests",
"//components/precache/content:unit_tests",
- "//components/precache/core:unit_tests",
- "//components/query_parser:unit_tests",
- "//components/rappor:unit_tests",
"//components/safe_browsing_db:unit_tests",
"//components/safe_json:unit_tests",
"//components/scheduler:unit_tests",
- "//components/search:unit_tests",
- "//components/search_engines:unit_tests",
- "//components/search_provider_logos:unit_tests",
- "//components/signin/core/browser:unit_tests",
- "//components/ssl_config:unit_tests",
- "//components/ssl_errors:unit_tests",
- "//components/sync_bookmarks:unit_tests",
- "//components/sync_driver:unit_tests",
- "//components/sync_sessions:unit_tests",
"//components/test_runner:test_runner",
"//components/tracing:unit_tests",
"//components/ui/zoom:unit_tests",
- "//components/url_formatter:unit_tests",
- "//components/url_matcher:unit_tests",
- "//components/user_prefs/tracked:unit_tests",
"//components/visitedlink/test:unit_tests",
"//components/wallpaper:unit_tests",
"//components/web_cache/browser:unit_tests",
"//components/webcrypto:unit_tests",
- "//components/webdata/common:unit_tests",
"//mojo/edk/system",
# These are the deps required by the code in this target.
« no previous file with comments | « no previous file | components/autofill/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698