Always enable warn-raw-ptr's check of raw heap pointers.

Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476
Committed: https://crrev.com/f3af836424457dc1e7310bc4aad6527f08094dd6
Cr-Commit-Position: refs/heads/master@{#388222}

[sof, 2016-04-19 07:17:56]

Description was changed from

==========
Always enable warn-raw-ptr's check of raw heap pointers.

R=
BUG=
==========

to

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=
==========

[sof, 2016-04-19 07:19:09]

Description was changed from

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=
==========

to

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476
==========

[sof, 2016-04-19 07:19:34]

sigbjornf@opera.com changed reviewers:
+ hans@chromium.org, oilpan-reviews@chromium.org, thakis@chromium.org

[sof, 2016-04-19 07:19:35]

please take a look.

[haraken, 2016-04-19 07:23:56]

LGTM

[sof, 2016-04-19 07:26:09]

hmm, looks like a patchset A dependent on B isn't able to delete a file in B
that was added by A.

(CL passes all GC plugin unit tests locally.)

[Nico, 2016-04-19 15:07:59]

Thanks! lgtm, but maybe there's more to delete:

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp (right):

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp:216:
diag_class_contains_invalid_fields_warning_ = diagnostic_.getCustomDiagID(
can this field go away now too?

[sof, 2016-04-19 15:22:24]

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp (right):

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp:216:
diag_class_contains_invalid_fields_warning_ = diagnostic_.getCustomDiagID(
On 2016/04/19 15:07:59, Nico wrote:
> can this field go away now too?

I considered it as it now-unused, but left it in. Happy to remove.

[Nico, 2016-04-19 15:24:04]

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp (right):

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp:216:
diag_class_contains_invalid_fields_warning_ = diagnostic_.getCustomDiagID(
On 2016/04/19 15:22:24, sof wrote:
> On 2016/04/19 15:07:59, Nico wrote:
> > can this field go away now too?
> 
> I considered it as it now-unused, but left it in. Happy to remove.

I'd remove it if it's unused.

[sof, 2016-04-19 15:36:56]

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp (right):

https://codereview.chromium.org/1901643003/diff/40001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp:216:
diag_class_contains_invalid_fields_warning_ = diagnostic_.getCustomDiagID(
On 2016/04/19 15:24:04, Nico wrote:
> On 2016/04/19 15:22:24, sof wrote:
> > On 2016/04/19 15:07:59, Nico wrote:
> > > can this field go away now too?
> > 
> > I considered it as it now-unused, but left it in. Happy to remove.
> 
> I'd remove it if it's unused.

I thought it had some finely crafted warning message associated with it, but
it's a duplicate of the one above. No reason to go slow in removing; gone now.

[sof, 2016-04-19 15:56:45]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-04-19 15:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1901643003/#ps60001
(title: "remove unused warning diagnostic")

[commit-bot: I haz the power, 2016-04-19 15:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901643003/60001

[commit-bot: I haz the power, 2016-04-19 16:41:55]

Description was changed from

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476
==========

to

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476
==========

[commit-bot: I haz the power, 2016-04-19 16:41:56]

Committed patchset #4 (id:60001)

[sof, 2016-04-19 18:18:39]

thakis@: if there's a tracker bug for the next roll, let me know - thanks. (no
rush with these two tidying changes.)

[Nico, 2016-04-19 19:01:50]

On 2016/04/19 18:18:39, sof wrote:
> thakis@: if there's a tracker bug for the next roll, let me know - thanks. (no
> rush with these two tidying changes.)

There isn't one yet (we rolled Friday). You're welcome to file one though :-)

[sof, 2016-04-20 05:30:08]

On 2016/04/19 19:01:50, Nico wrote:
> On 2016/04/19 18:18:39, sof wrote:
> > thakis@: if there's a tracker bug for the next roll, let me know - thanks.
(no
> > rush with these two tidying changes.)
> 
> There isn't one yet (we rolled Friday). You're welcome to file one though :-)

ok, that would be the 'least' I could do :) https://crbug.com/604993

[commit-bot: I haz the power, 2016-04-22 19:12:49]

Description was changed from

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476
==========

to

==========
Always enable warn-raw-ptr's check of raw heap pointers.

This warning option has been default-enabled with Oilpan since 3a192c3
(2015-11-25), checking that we do not keep unmanaged raw pointers or
references in class field types. With the Blink codebase adhering
to that (desirable) constraint, this extra warning has been working
well to keep the codebase in that state.

Make the check always apply with no possibility of opting out; we want
it permanently on.

R=
BUG=604476

Committed: https://crrev.com/f3af836424457dc1e7310bc4aad6527f08094dd6
Cr-Commit-Position: refs/heads/master@{#388222}
==========

[commit-bot: I haz the power, 2016-04-22 19:12:50]

Patchset 4 (id:??) landed as
https://crrev.com/f3af836424457dc1e7310bc4aad6527f08094dd6
Cr-Commit-Position: refs/heads/master@{#388222}