Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sof-gc-plugin-upd
Patch Set: remove unused warning diagnostic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp
diff --git a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp
index b4eb04b5d0d88aecd8d7ed8bdb8ac233b30d0108..f08710f88479595b5077eb4f5b9540e97ef5d946 100644
--- a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp
+++ b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp
@@ -93,14 +93,11 @@ void CheckFieldsVisitor::AtValue(Value* edge) {
current_, InvalidSmartPtr(Parent())));
return;
}
- if (options_.warn_raw_ptr && Parent()->IsRawPtr()) {
- if (static_cast<RawPtr*>(Parent())->HasReferenceType()) {
- invalid_fields_.push_back(std::make_pair(
- current_, kReferencePtrToGCManagedWarning));
- } else {
- invalid_fields_.push_back(std::make_pair(
- current_, kRawPtrToGCManagedWarning));
- }
+ if (Parent()->IsRawPtr()) {
+ RawPtr* rawPtr = static_cast<RawPtr*>(Parent());
+ Error error = rawPtr->HasReferenceType() ?
+ kReferencePtrToGCManaged : kRawPtrToGCManaged;
+ invalid_fields_.push_back(std::make_pair(current_, error));
}
}
@@ -109,24 +106,6 @@ void CheckFieldsVisitor::AtCollection(Collection* edge) {
invalid_fields_.push_back(std::make_pair(current_, kOwnPtrToGCManaged));
}
-bool CheckFieldsVisitor::IsWarning(Error error) {
- if (error == kRawPtrToGCManagedWarning)
- return true;
- if (error == kReferencePtrToGCManagedWarning)
- return true;
- return false;
-}
-
-bool CheckFieldsVisitor::IsRawPtrError(Error error) {
- return (error == kRawPtrToGCManaged ||
- error == kRawPtrToGCManagedWarning);
-}
-
-bool CheckFieldsVisitor::IsReferencePtrError(Error error) {
- return (error == kReferencePtrToGCManaged ||
- error == kReferencePtrToGCManagedWarning);
-}
-
CheckFieldsVisitor::Error CheckFieldsVisitor::InvalidSmartPtr(Edge* ptr) {
if (ptr->IsRawPtr()) {
if (static_cast<RawPtr*>(ptr)->HasReferenceType())
« no previous file with comments | « tools/clang/blink_gc_plugin/CheckFieldsVisitor.h ('k') | tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698