Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h

Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sof-gc-plugin-upd
Patch Set: remove unused warning diagnostic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ 5 #ifndef TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_
6 #define TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ 6 #define TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "Edge.h" 10 #include "Edge.h"
11 11
12 struct BlinkGCPluginOptions; 12 struct BlinkGCPluginOptions;
13 class FieldPoint; 13 class FieldPoint;
14 14
15 // This visitor checks that the fields of a class are "well formed". 15 // This visitor checks that the fields of a class are "well formed".
16 // - OwnPtr and RefPtr must not point to a GC derived type. 16 // - OwnPtr and RefPtr must not point to a GC derived type.
17 // - Part objects must not be a GC derived type. 17 // - Part objects must not be a GC derived type.
18 // - An on-heap class must never contain GC roots. 18 // - An on-heap class must never contain GC roots.
19 // - Only stack-allocated types may point to stack-allocated types. 19 // - Only stack-allocated types may point to stack-allocated types.
20 20
21 class CheckFieldsVisitor : public RecursiveEdgeVisitor { 21 class CheckFieldsVisitor : public RecursiveEdgeVisitor {
22 public: 22 public:
23 enum Error { 23 enum Error {
24 kRawPtrToGCManaged, 24 kRawPtrToGCManaged,
25 kRawPtrToGCManagedWarning,
26 kRefPtrToGCManaged, 25 kRefPtrToGCManaged,
27 kReferencePtrToGCManaged, 26 kReferencePtrToGCManaged,
28 kReferencePtrToGCManagedWarning,
29 kOwnPtrToGCManaged, 27 kOwnPtrToGCManaged,
30 kMemberToGCUnmanaged, 28 kMemberToGCUnmanaged,
31 kMemberInUnmanaged, 29 kMemberInUnmanaged,
32 kPtrFromHeapToStack, 30 kPtrFromHeapToStack,
33 kGCDerivedPartObject 31 kGCDerivedPartObject
34 }; 32 };
35 33
36 typedef std::vector<std::pair<FieldPoint*, Error> > Errors; 34 typedef std::vector<std::pair<FieldPoint*, Error> > Errors;
37 35
38 explicit CheckFieldsVisitor(const BlinkGCPluginOptions& options); 36 explicit CheckFieldsVisitor(const BlinkGCPluginOptions& options);
39 37
40 Errors& invalid_fields(); 38 Errors& invalid_fields();
41 39
42 bool ContainsInvalidFields(RecordInfo* info); 40 bool ContainsInvalidFields(RecordInfo* info);
43 41
44 void AtMember(Member* edge) override; 42 void AtMember(Member* edge) override;
45 void AtValue(Value* edge) override; 43 void AtValue(Value* edge) override;
46 void AtCollection(Collection* edge) override; 44 void AtCollection(Collection* edge) override;
47 45
48 static bool IsWarning(Error error);
49 static bool IsRawPtrError(Error error);
50 static bool IsReferencePtrError(Error error);
51
52 private: 46 private:
53 Error InvalidSmartPtr(Edge* ptr); 47 Error InvalidSmartPtr(Edge* ptr);
54 48
55 const BlinkGCPluginOptions& options_; 49 const BlinkGCPluginOptions& options_;
56 FieldPoint* current_; 50 FieldPoint* current_;
57 bool stack_allocated_host_; 51 bool stack_allocated_host_;
58 bool managed_host_; 52 bool managed_host_;
59 Errors invalid_fields_; 53 Errors invalid_fields_;
60 }; 54 };
61 55
62 #endif // TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ 56 #endif // TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h ('k') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698