Always enable warn-raw-ptr's check of raw heap pointers.

tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "CheckFieldsVisitor.h"
 
 #include <cassert>
 
 #include "BlinkGCPluginOptions.h"
 #include "RecordInfo.h"
@@ skipping 75 matching lines @@
     return;
 
   // Disallow  OwnPtr<T>, RefPtr<T> and T* to stack-allocated types.
   if (Parent()->IsOwnPtr() ||
       (Parent()->IsRefPtr() && !edge->value()->IsGCRefCounted()) ||
       (stack_allocated_host_ && Parent()->IsRawPtr())) {
     invalid_fields_.push_back(std::make_pair(
         current_, InvalidSmartPtr(Parent())));
     return;
   }
-  if (options_.warn_raw_ptr && Parent()->IsRawPtr()) {
-    if (static_cast<RawPtr*>(Parent())->HasReferenceType()) {
-      invalid_fields_.push_back(std::make_pair(
-          current_, kReferencePtrToGCManagedWarning));
-    } else {
-      invalid_fields_.push_back(std::make_pair(
-          current_, kRawPtrToGCManagedWarning));
-    }
+  if (Parent()->IsRawPtr()) {
+    RawPtr* rawPtr = static_cast<RawPtr*>(Parent());
+    Error error = rawPtr->HasReferenceType() ?
+        kReferencePtrToGCManaged : kRawPtrToGCManaged;
+    invalid_fields_.push_back(std::make_pair(current_, error));
   }
 }
 
 void CheckFieldsVisitor::AtCollection(Collection* edge) {
   if (edge->on_heap() && Parent() && Parent()->IsOwnPtr())
     invalid_fields_.push_back(std::make_pair(current_, kOwnPtrToGCManaged));
 }
 
-bool CheckFieldsVisitor::IsWarning(Error error) {
-  if (error == kRawPtrToGCManagedWarning)
-    return true;
-  if (error == kReferencePtrToGCManagedWarning)
-    return true;
-  return false;
-}
-
-bool CheckFieldsVisitor::IsRawPtrError(Error error) {
-  return (error == kRawPtrToGCManaged ||
-          error == kRawPtrToGCManagedWarning);
-}
-
-bool CheckFieldsVisitor::IsReferencePtrError(Error error) {
-  return (error == kReferencePtrToGCManaged ||
-          error == kReferencePtrToGCManagedWarning);
-}
-
 CheckFieldsVisitor::Error CheckFieldsVisitor::InvalidSmartPtr(Edge* ptr) {
   if (ptr->IsRawPtr()) {
     if (static_cast<RawPtr*>(ptr)->HasReferenceType())
       return kReferencePtrToGCManaged;
     else
       return kRawPtrToGCManaged;
   }
   if (ptr->IsRefPtr())
     return kRefPtrToGCManaged;
   if (ptr->IsOwnPtr())
     return kOwnPtrToGCManaged;
   assert(false && "Unknown smart pointer kind");
 }