Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h

Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sof-gc-plugin-upd
Patch Set: remove unused warning diagnostic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
diff --git a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
index 5264572be0f881f413ac9d64b773adfa6819d650..d700be2ae0201fc78f49389721580da92daad116 100644
--- a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
+++ b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
@@ -22,10 +22,8 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
public:
enum Error {
kRawPtrToGCManaged,
- kRawPtrToGCManagedWarning,
kRefPtrToGCManaged,
kReferencePtrToGCManaged,
- kReferencePtrToGCManagedWarning,
kOwnPtrToGCManaged,
kMemberToGCUnmanaged,
kMemberInUnmanaged,
@@ -45,10 +43,6 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
void AtValue(Value* edge) override;
void AtCollection(Collection* edge) override;
- static bool IsWarning(Error error);
- static bool IsRawPtrError(Error error);
- static bool IsReferencePtrError(Error error);
-
private:
Error InvalidSmartPtr(Edge* ptr);
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h ('k') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698