Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sof-gc-plugin-upd
Patch Set: remove unused warning diagnostic Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
index 7c21061e5ac18813b3d63742a5a86f5cb755827a..85140bb380c5ce5d52f63ea0cdf8c94c62d8a423 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
@@ -39,10 +39,11 @@ class BlinkGCPluginAction : public PluginASTAction {
// Blink no longer passes in the option (cf. Source/config.gyp)
if (args[i] == "enable-oilpan")
continue;
+ // TODO(sof): same for warn-raw-ptr
+ if (args[i] == "warn-raw-ptr")
+ continue;
if (args[i] == "dump-graph") {
options_.dump_graph = true;
- } else if (args[i] == "warn-raw-ptr") {
- options_.warn_raw_ptr = true;
} else if (args[i] == "warn-unneeded-finalizer") {
options_.warn_unneeded_finalizer = true;
} else {
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698