tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h - Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

Issue 1901643003: Always enable warn-raw-ptr's check of raw heap pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sof-gc-plugin-upd

Patch Set: remove unused warning diagnostic Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h b/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

index 52e648413929706ccf20a76db69bf6bd20fb8d80..b941f0864562fc4d4d088022a7a8c8d8574f6428 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

@@ -12,10 +12,8 @@

struct BlinkGCPluginOptions {

BlinkGCPluginOptions()

: dump_graph(false),

- warn_raw_ptr(false),

warn_unneeded_finalizer(false) {}

bool dump_graph;

- bool warn_raw_ptr;

bool warn_unneeded_finalizer;

std::set<std::string> ignored_classes;

std::set<std::string> checked_namespaces;

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp ('k') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.h » ('j') | no next file with comments »