Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed)

Created:
4 years, 8 months ago by lijeffrey
Modified:
4 years, 8 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Adding support for disabling test try jobs for given master/builder BUG=604102 Committed: https://chromium.googlesource.com/infra/infra/+/f123ea892a526cbd5f204b367fa6d3d0443c0416

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -4 lines) Patch
M appengine/findit/handlers/config.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/findit/handlers/test/config_test.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/try_job_util_test.py View 1 2 chunks +20 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/test/waterfall_config_test.py View 1 2 chunks +10 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/wf_testcase.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/try_job_util.py View 1 2 chunks +8 lines, -1 line 2 comments Download
M appengine/findit/waterfall/waterfall_config.py View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lijeffrey
ptal
4 years, 8 months ago (2016-04-16 00:50:34 UTC) #2
stgao
https://codereview.chromium.org/1898493002/diff/1/appengine/findit/handlers/config.py File appengine/findit/handlers/config.py (right): https://codereview.chromium.org/1898493002/diff/1/appengine/findit/handlers/config.py#newcode144 appengine/findit/handlers/config.py:144: if (trybot_config.has_key('enable_tests') and Is seems we only want to ...
4 years, 8 months ago (2016-04-16 01:04:04 UTC) #3
lijeffrey
https://codereview.chromium.org/1898493002/diff/1/appengine/findit/handlers/config.py File appengine/findit/handlers/config.py (right): https://codereview.chromium.org/1898493002/diff/1/appengine/findit/handlers/config.py#newcode144 appengine/findit/handlers/config.py:144: if (trybot_config.has_key('enable_tests') and On 2016/04/16 01:04:04, stgao wrote: > ...
4 years, 8 months ago (2016-04-16 02:57:28 UTC) #4
stgao
lgtm lgtm with a nit which should be fixed in a follow-up CL. https://codereview.chromium.org/1898493002/diff/20001/appengine/findit/waterfall/try_job_util.py File ...
4 years, 8 months ago (2016-04-16 06:33:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898493002/20001
4 years, 8 months ago (2016-04-16 06:33:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/f123ea892a526cbd5f204b367fa6d3d0443c0416
4 years, 8 months ago (2016-04-16 06:37:37 UTC) #9
lijeffrey
4 years, 8 months ago (2016-04-18 21:40:41 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1898493002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/try_job_util.py (right):

https://codereview.chromium.org/1898493002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:162: _NeedANewTryJob(master_name,
builder_name, build_number,
On 2016/04/16 06:33:15, stgao wrote:
> If _NeedANewTryJob is run, a TryJob entity is created already.
> We need to fix this.

Addressed in https://codereview.chromium.org/1898003002/

Powered by Google App Engine
This is Rietveld 408576698