Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3069)

Unified Diff: appengine/findit/waterfall/test/waterfall_config_test.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/waterfall_config_test.py
diff --git a/appengine/findit/waterfall/test/waterfall_config_test.py b/appengine/findit/waterfall/test/waterfall_config_test.py
index e3098243fdfbb98d6eded98a04d91fc2638f55a6..3f6c2ee70631ca57575769ba91b01fc962c9c25e 100644
--- a/appengine/findit/waterfall/test/waterfall_config_test.py
+++ b/appengine/findit/waterfall/test/waterfall_config_test.py
@@ -76,7 +76,7 @@ class MastersTest(wf_testcase.WaterfallTestCase):
waterfall_config.GetTrybotForWaterfallBuilder('master1', 'builder1'))
self.assertEqual(
(None, None),
- waterfall_config.GetTrybotForWaterfallBuilder('master2', 'builder2'))
+ waterfall_config.GetTrybotForWaterfallBuilder('master3', 'builder3'))
def testGetTryJobSettings(self):
self.assertEqual(
@@ -107,3 +107,12 @@ class MastersTest(wf_testcase.WaterfallTestCase):
self.assertTrue(
waterfall_config.EnableStrictRegexForCompileLinkFailures(
'master1', 'builder1'))
+
+ def testShouldSkipTestTryJobs(self):
+ self.assertFalse(
+ waterfall_config.ShouldSkipTestTryJobs('master1', 'builder1'))
+ self.assertFalse(
+ waterfall_config.ShouldSkipTestTryJobs('master2', 'builder3'))
+ self.assertTrue(
+ waterfall_config.ShouldSkipTestTryJobs('master2', 'builder2'))
+

Powered by Google App Engine
This is Rietveld 408576698