Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 66efb2281641ca17fdf6efeb2ee69bd22561cc05..2014e3eee26fad42c0fe1f52b45e58cef504bb07 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -26,8 +26,8 @@ class _MockRootPipeline(object):
class TryJobUtilTest(wf_testcase.WaterfallTestCase):
def testNotNeedANewTryJobIfBuilderIsNotSupportedYet(self):
- master_name = 'master2'
- builder_name = 'builder2'
+ master_name = 'master3'
+ builder_name = 'builder3'
build_number = 223
failure_info = {
'master_name': master_name,
@@ -71,6 +71,24 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
self.assertFalse(_MockRootPipeline.STARTED)
self.assertEqual({}, failure_result_map)
+ def testBailOutForTestTryJob(self):
+ master_name = 'master2'
+ builder_name = 'builder2'
+ build_number = 223
+ failure_info = {
+ 'master_name': master_name,
+ 'builder_name': builder_name,
+ 'build_number': build_number,
+ 'failed_steps': {
+ 'a_test': {}
+ },
+ }
+
+ failure_result_map = try_job_util.ScheduleTryJobIfNeeded(
+ failure_info, None, None)
+
+ self.assertEqual({}, failure_result_map)
+
def testNotNeedANewTryJobIfNotFirstTimeFailure(self):
master_name = 'm'
builder_name = 'b'

Powered by Google App Engine
This is Rietveld 408576698