appengine/findit/handlers/config.py - Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/config.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/handlers/config.py

diff --git a/appengine/findit/handlers/config.py b/appengine/findit/handlers/config.py

index 59b8191482f868db986bb86e1cadc96ae60501e8..1916a6b30cea98974ed65a1aa507216b8c001cd2 100644

--- a/appengine/findit/handlers/config.py

+++ b/appengine/findit/handlers/config.py

@@ -141,6 +141,9 @@ def _ValidateTrybotMapping(builders_to_trybots):

if (trybot_config.has_key('strict_regex') and

not isinstance(trybot_config['strict_regex'], bool)):

return False

+ if (trybot_config.has_key('not_run_tests') and

+ not isinstance(trybot_config['not_run_tests'], bool)):

+ return False

return True

« no previous file with comments | « no previous file | appengine/findit/handlers/test/config_test.py » ('j') | appengine/findit/waterfall/try_job_util.py » ('J')