Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2525)

Unified Diff: appengine/findit/handlers/test/config_test.py

Issue 1898493002: [Findit] Adding support for disabling test try jobs for given master/builder (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/test/config_test.py
diff --git a/appengine/findit/handlers/test/config_test.py b/appengine/findit/handlers/test/config_test.py
index 0482afc32af4c3302a858e85d39e487a79bd93ed..02e14bfce971f0853b2feaa120996b2991ea09b8 100644
--- a/appengine/findit/handlers/test/config_test.py
+++ b/appengine/findit/handlers/test/config_test.py
@@ -413,6 +413,24 @@ class ConfigTest(testing.AppengineTestCase):
}
}
}))
+ self.assertTrue(config._ValidateTrybotMapping({
+ 'master1': {
+ 'builder1': {
+ 'mastername': 'tryserver1',
+ 'buildername': 'trybot1',
+ 'not_run_tests': True,
+ }
+ }
+ }))
+ self.assertFalse(config._ValidateTrybotMapping({
+ 'master1': {
+ 'builder1': {
+ 'mastername': 'tryserver1',
+ 'buildername': 'trybot1',
+ 'not_run_tests': 1, # Should be a bool.
+ }
+ }
+ }))
self.assertFalse(config._ValidateTrybotMapping(['a']))
self.assertFalse(config._ValidateTrybotMapping({'a': ['b']}))
self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}}))

Powered by Google App Engine
This is Rietveld 408576698